From: Vitaly Wool <vwool@ru.mvista.com>
To: "Alexey, Korolev" <alexey.korolev@intel.com>
Cc: tglx@linutronix.de, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] Fixup in NAND bad block management + fix of misspring.(nand_base.c)
Date: Mon, 20 Feb 2006 15:08:11 +0300 [thread overview]
Message-ID: <43F9B12B.7020903@ru.mvista.com> (raw)
In-Reply-To: <43F9AE68.4040206@intel.com>
Alexey,
Alexey, Korolev wrote:
> Thomas,
>
>> I still do not get why you need all this magic instead of fixing up
>> this->badblockpos in the first place.
>>
> Fixing this->badblockpos in low level driver will not help because,
> according to the code this->badblockpos updates in nand_base.c
> unconditionally.
> Moreover it's rather hard to define the conditions, because by default
> structure "this" is filled by zeroes. (We can't distinguish advisedly
> setting of badblockpos from the default value).
Well, maybe I'm missting something, but what prevents you from setting
this->badblockpos to 0 *after* call to nand_scan??
Best regards,
Vitaly
next prev parent reply other threads:[~2006-02-20 12:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-20 15:44 [PATCH] Fixup in NAND bad block management + fix of misspring . (nand_base.c) Alexey, Korolev
2006-02-08 16:05 ` [PATCH] Fixup in NAND bad block management + fix of misspring .(nand_base.c) Alexey, Korolev
2006-02-08 20:11 ` Vitaly Wool
2006-02-09 17:54 ` Alexey, Korolev
2006-03-12 15:18 ` Thomas Gleixner
2006-02-09 18:03 ` Alexey, Korolev
2006-02-10 6:52 ` Vitaly Wool
2006-02-20 10:53 ` Alexey, Korolev
2006-02-20 11:00 ` Thomas Gleixner
2006-02-20 11:56 ` [PATCH] Fixup in NAND bad block management + fix of misspring.(nand_base.c) Alexey, Korolev
2006-02-20 12:08 ` Vitaly Wool [this message]
2006-02-20 12:11 ` Thomas Gleixner
2006-03-02 17:29 ` [PATCH] Fixup in NAND bad block management + fix ofmisspring.(nand_base.c) Alexey, Korolev
2006-03-12 16:44 ` Thomas Gleixner
2006-03-20 14:06 ` [PATCH] Fixup in NAND bad block management + fixofmisspring.(nand_base.c) Alexey, Korolev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43F9B12B.7020903@ru.mvista.com \
--to=vwool@ru.mvista.com \
--cc=alexey.korolev@intel.com \
--cc=linux-mtd@lists.infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.