From: Rojhalat Ibrahim <imr@rtschenk.de>
To: "Kevin D. Kissell" <kevink@mips.com>
Cc: Mark E Mason <mark.e.mason@broadcom.com>, linux-mips@linux-mips.org
Subject: Re: Tracking down exception in sched.c
Date: Mon, 20 Feb 2006 15:28:37 +0100 [thread overview]
Message-ID: <43F9D215.3090506@rtschenk.de> (raw)
In-Reply-To: <43F9C58E.4020606@mips.com>
Kevin D. Kissell wrote:
> The "for" loop is what used to be there, but if you use it in
> a system with "hot-pluggable" CPUs, I could imagine that there
> would be problems. While for_each_cpu is pathetically inefficient
> as it gets expanded and compiled for MIPS, if your phys_cpu_present_map
> (which is by default what gets used in MIPS as cpu_possible_map
> for the purposes of sched.c) is being properly initialized and
> maintained, the behavior of the two loops should be the same.
> Have you double-checked that? Secondary CPUs turn generally
> set their bits in that mask in prom_build_cpu_map().
>
The behavior of the two loops is not the same because sched_init
is called long before smp_prepare_cpus. Therefore for_each_cpu
only loops once for CPU 0. I know this is not a great fix.
I simply reverted the code to what's worked before.
Rojhalat Ibrahim
next prev parent reply other threads:[~2006-02-20 14:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-10 23:18 Tracking down exception in sched.c Mark E Mason
2006-02-20 12:09 ` Rojhalat Ibrahim
2006-02-20 13:35 ` Kevin D. Kissell
2006-02-20 14:28 ` Rojhalat Ibrahim [this message]
2006-02-20 14:52 ` Kevin D. Kissell
2006-02-20 14:52 ` Kevin D. Kissell
2006-02-20 20:27 ` Kevin D. Kissell
2006-02-21 1:46 ` Ralf Baechle
2006-02-20 14:40 ` Kevin D. Kissell
2006-02-20 14:40 ` Kevin D. Kissell
2006-02-20 13:35 ` Ralf Baechle
2006-02-20 14:35 ` Kevin D. Kissell
2006-02-20 14:35 ` Kevin D. Kissell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43F9D215.3090506@rtschenk.de \
--to=imr@rtschenk.de \
--cc=kevink@mips.com \
--cc=linux-mips@linux-mips.org \
--cc=mark.e.mason@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.