From: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
To: Michael Richardson <mcr@xelerance.com>
Cc: kuznet@ms2.inr.ac.ru,
netfilter-devel <netfilter-devel@lists.netfilter.org>,
Jamal Hadi Salim <hadi@cyberus.ca>,
netdev@vger.kernel.org
Subject: Re: [PATCH 02/02] add mask options to fwmark masking code
Date: Mon, 20 Feb 2006 20:58:39 +0100 [thread overview]
Message-ID: <43FA1F6F.2080408@gmx.net> (raw)
In-Reply-To: <23140.1140452813@sandelman.ottawa.on.ca>
Michael Richardson schrieb:
> [PATCH] This patch introduces a mask to the fwmark test cases in the advanced
> routing. This let's one test individual bits of the fwmark to determine
> how things should be routed (pick a routing table). This patch retains
> compatibility with tests that do not set the mask by assuming a mask
> of 0 is equivalent to a mask of 0xffffffff.
Sorry if I misunderstood the intention of your patch, but isn't similar code
already in mainline?
linux-2.6.16-rc3/net/sched/cls_u32.c:146
#ifdef CONFIG_CLS_U32_MARK
if ((skb->nfmark & n->mark.mask) != n->mark.val) {
Regards,
Carl-Daniel
--
http://www.hailfinger.org/
prev parent reply other threads:[~2006-02-20 19:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-20 16:26 [PATCH 02/02] add mask options to fwmark masking code Michael Richardson
2006-02-20 16:57 ` Patrick McHardy
2006-02-23 19:36 ` Michael Richardson
2006-02-24 4:58 ` Patrick McHardy
2006-02-20 17:16 ` Patrick McHardy
2006-02-20 19:58 ` Carl-Daniel Hailfinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43FA1F6F.2080408@gmx.net \
--to=c-d.hailfinger.devel.2006@gmx.net \
--cc=hadi@cyberus.ca \
--cc=kuznet@ms2.inr.ac.ru \
--cc=mcr@xelerance.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.