From: Nick Piggin <nickpiggin@yahoo.com.au>
To: David Gibson <dwg@au1.ibm.com>
Cc: William Lee Irwin <wli@holomorphy.com>, linux-kernel@vger.kernel.org
Subject: Re: RFC: Block reservation for hugetlbfs
Date: Wed, 22 Feb 2006 11:38:42 +1100 [thread overview]
Message-ID: <43FBB292.1000304@yahoo.com.au> (raw)
In-Reply-To: <20060221233950.GB20872@localhost.localdomain>
David Gibson wrote:
> On Tue, Feb 21, 2006 at 03:18:59PM +1100, Nick Piggin wrote:
>>This introduces
>>tree_lock(r) -> hugetlb_lock
>>
>>And we already have
>>hugetlb_lock -> lru_lock
>>
>>So we now have tree_lock(r) -> lru_lock, which would deadlock
>>against lru_lock -> tree_lock(w), right?
>>
>>From a quick glance it looks safe, but I'd _really_ rather not
>>introduce something like this.
>
>
> Urg.. good point. I hadn't even thought of that consequence - I was
> more worried about whether I need i_lock or i_mutex to protect my
> updates to i_blocks.
>
> Would hugetlb_lock -> tree_lock(r) be any preferable (I think that's a
> possible alternative).
>
Yes I think that should avoid the introduction of new lock dependency.
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2006-02-22 1:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-21 2:21 RFC: Block reservation for hugetlbfs David Gibson
2006-02-21 4:18 ` Nick Piggin
2006-02-21 23:39 ` David Gibson
2006-02-22 0:38 ` Nick Piggin [this message]
2006-02-22 2:11 ` David Gibson
2006-02-22 3:09 ` Nick Piggin
2006-02-24 4:11 ` David Gibson
2006-02-24 6:22 ` Nick Piggin
2006-02-27 0:18 ` David Gibson
2006-02-21 19:25 ` Dave Hansen
2006-02-21 23:46 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43FBB292.1000304@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=dwg@au1.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.