All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: xen-devel <xen-devel@lists.xensource.com>
Subject: [PATCH] don't require ebtables in the host kernel
Date: Wed, 22 Feb 2006 10:54:51 +0200	[thread overview]
Message-ID: <43FC26DB.7060906@qumranet.com> (raw)

The network-bridge script fails when setting a few sysctls
which are only available if ebtables is present in the host
kernel. Fix by ignoring the return value of the sysctl command.

Signed-off-by: Avi Kivity <avi@qumranet.com>

Index: xen/tools/examples/network-bridge
===================================================================
--- xen/tools/examples/network-bridge	(revision 991)
+++ xen/tools/examples/network-bridge	(revision 992)
@@ -158,9 +158,9 @@
 
     # Don't create the bridge if it already exists.
     if ! brctl show | grep -q ${bridge} ; then
-	sysctl -w "net.bridge.bridge-nf-call-arptables=0"
-	sysctl -w "net.bridge.bridge-nf-call-ip6tables=0"
-	sysctl -w "net.bridge.bridge-nf-call-iptables=0"
+	! sysctl -w "net.bridge.bridge-nf-call-arptables=0"
+	! sysctl -w "net.bridge.bridge-nf-call-ip6tables=0"
+	! sysctl -w "net.bridge.bridge-nf-call-iptables=0"
 	brctl addbr ${bridge}
 	brctl stp ${bridge} off
 	brctl setfd ${bridge} 0


-- 
error compiling committee.c: too many arguments to function

             reply	other threads:[~2006-02-22  8:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-22  8:54 Avi Kivity [this message]
2006-02-22 13:33 ` [PATCH] don't require ebtables in the host kernel Ewan Mellor
2006-02-22 14:23   ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43FC26DB.7060906@qumranet.com \
    --to=avi@qumranet.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.