All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Vogl <simon.vogl@researchstudios.at>
To: linux-mtd@lists.infradead.org
Subject: [PATCH] cfi: init wait queue in chip struct
Date: Wed, 22 Feb 2006 15:41:31 +0100	[thread overview]
Message-ID: <43FC781B.5030608@researchstudios.at> (raw)

This patch fixes a kernel oops for Intel P30 flashes, where
the wait queue head was not initialized for the flchip struct, which 
in turn caused a crash at the first read operation.
Simon

diff -ur linux-2.6.15.4.mtd-git/drivers/mtd/chips/cfi_cmdset_0001.c linux-2.6.15.4/drivers/mtd/chips/cfi_cmdset_0001.c
--- linux-2.6.15.4.mtd-git/drivers/mtd/chips/cfi_cmdset_0001.c	2006-02-21 15:23:34.000000000 +0100
+++ linux-2.6.15.4/drivers/mtd/chips/cfi_cmdset_0001.c	2006-02-22 11:48:29.000000000 +0100
@@ -408,6 +408,7 @@
 		cfi->chips[i].buffer_write_time = 1<<cfi->cfiq->BufWriteTimeoutTyp;
 		cfi->chips[i].erase_time = 1<<cfi->cfiq->BlockEraseTimeoutTyp;
 		cfi->chips[i].ref_point_counter = 0;
+		init_waitqueue_head(&(cfi->chips[i].wq));
 	}
 
 	map->fldrv = &cfi_intelext_chipdrv;


-- 
_______________________________________________________________________
Dr. Simon Vogl
ARC Seibersdorf research GmbH
Research Studios Austria, Studio Pervasive Computing Applications
Aubrunnerweg 1, A-4040 Linz, Austria  
  
Tel: +43 732 2468-5350, Fax: +43 732 2468-25350
mailto: simon.vogl@researchstudio.at

             reply	other threads:[~2006-02-22 14:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-22 14:41 Simon Vogl [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-02-22 14:29 [PATCH] cfi: init wait queue in chip struct Simon Vogl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43FC781B.5030608@researchstudios.at \
    --to=simon.vogl@researchstudios.at \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.