Re: [KJ] [Patch] kzalloc conversion in fs/proc

[Jaco Kroon <jaco@kroon.co.za>]

[-- Attachment #1.1: Type: text/plain, Size: 1401 bytes --]

Nishanth Aravamudan wrote:
> On 22.02.2006 [22:14:25 +0300], Alexey Dobriyan wrote:
> 
>>On Wed, Feb 22, 2006 at 01:14:39AM +0100, Jesper Juhl wrote:
>>
>>>On 2/22/06, Eric Sesterhenn <snakebyte@gmx.de> wrote:
>>>
>>>>On Wed, 2006-02-22 at 00:13 +0100, Jesper Juhl wrote:
>>>>
>>>>>This looks broken - did you even compile test that patch?
>>>>>
>>>>>Don't you mean :
>>>>>
>>>>>return kzalloc(sizeof(struct vmcore), GFP_KERNEL);
>>>>
>>>>*yuck*, sorry for this, didnt compile test since it doesnt build
>>>>with my config. fixed patch below.
>>>>
>>>
>>>Hmm, a simple
>>>
>>>$ make allyesconfig
>>>$ make fs/proc/kcore.o
>>
>>How on earth did this succeed? I always, always get
> 
> 
> I'm guessing it might have been a tree he's already built a kernel in
> before? You usually need to let a normal make go through a few steps
> before trying this, so that the asm->asm-$arch symlink is created and a
> few other files are generated, IIRC.

That imho constitutes a dependancy bug in the build process.  After all,
it is rather obvious from the error that include/linux/sched.h depends
on asm/param.h, but obviously param.h doesn't exist yet.  Presumably
this is due to the asm link not being created yet.  But surely there is
a way to "force" the issue with make?

Jaco
-- 
There are only 10 kinds of people in this world,
  those that understand binary and those that don't.
http://www.kroon.co.za/

[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/x-pkcs7-signature, Size: 3233 bytes --]

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors