All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gregor Maier <gregor@net.in.tum.de>
To: netfilter-devel@lists.netfilter.org
Subject: libnetfilter_queue large packets problem
Date: Thu, 23 Feb 2006 23:44:24 +0100	[thread overview]
Message-ID: <43FE3AC8.7000809@net.in.tum.de> (raw)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

I think I encountered a problem when using libnetfilter_queue with
packets larger than the recv buffer specified when recv()-ing from the
socket of the queue.

The kernel truncates(*) the packet delivered to userspace an thus
nfnl_handle_packet() returns -1 (**), since there's a mismatch between
the length of the buffer and the recorded length in struct nlmsghdr.
This means that the callback function is never called an therefore we
are never able to issue a verdict for the packet and the packet is stuck
forever.

I think the best solution would be, if the callback would be called and
informed about the truncation, so that the callback can deside about the
fate of the packet.


A workaround is to make the buffer large enough for any possible packet
(i.e. 65535 + x for IP, with x being the number of bytes occupied by the
 netlink data structures)


This is almost certainly the cause of bug
https://bugzilla.netfilter.org/bugzilla/show_bug.cgi?id=404


(*) when I use recvmsg then the MSG_TRUNC flag is set for such packets
and peek in the netlink code asserted this.


(**)if (nlh->nlmsg_len < sizeof(struct nlmsghdr)
                    || len < nlh->nlmsg_len)
                        return -1;


cu
Gregor
- --
Gregor Maier                                      Lehrstuhl Informatik 8
gregor@net.in.tum.de                              Tel: +49 89  289-18010
http://www.net.in.tum.de                                     TU Muenchen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (Darwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFD/jrIdGiwgbikMYMRAobwAJ43bEBBs2FOEeFCjPRILln1XChZNgCbBysE
FKmJXJQGe2A6jaTnC8xGlEM=
=YQIG
-----END PGP SIGNATURE-----

             reply	other threads:[~2006-02-23 22:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-23 22:44 Gregor Maier [this message]
2006-02-24  5:16 ` libnetfilter_queue large packets problem Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43FE3AC8.7000809@net.in.tum.de \
    --to=gregor@net.in.tum.de \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.