Re: [PATCH 4/5] fbdev: Make BIOS EDID reading configurable

["Antonino A. Daplas" <adaplas@gmail.com>]

Andrew Morton wrote:
> "Antonino A. Daplas" <adaplas@gmail.com> wrote:
>> DDC reading via the Video BIOS may take several tens of seconds with
>>  some combination of display cards and monitors.
>>
>>  Make this option configurable and select only for drivers that need it.
> 
> But that's not what the patch actually does - it requires that the user
> select the option.

You got me there :-).  Initially, I had:

select FB_FIRMWARE_EDID if ...

in Kconfig on selected drivers, but in the end removed it.  And, I forgot
to change the changelog.

The reason I removed the "select ..." part is because the user won't be
able to deselect this option.
 
> 
> Also, is it not possible to defer this operation until we've parsed the
> command line, control it with a kernel boot parameter?
> 

I thought of that, but it seems a bit complicated to me to parse boot
options in assembly so I left this for another time.

The firmware EDID is only used as fallback, or if drivers have no DDC/I2C
support. Currently, all drivers that use the firmware EDID also have I2C
support in place. And chances are, if DDC transfers failed, the firmware
EDID will also be absent.

Tony


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642