All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tilman Schmidt <tilman@imap.cc>
To: linux-usb-devel@lists.sourceforge.net
Cc: hjlipp@web.de, linux-kernel@vger.kernel.org
Subject: [PATCH] reduce syslog clutter
Date: Fri, 24 Feb 2006 10:50:52 +0100	[thread overview]
Message-ID: <43FED6FC.3090604@imap.cc> (raw)

[-- Attachment #1: Type: text/plain, Size: 1518 bytes --]

The current versions of the err() / info() / warn() syslog macros
insert __FILE__ at the beginning of the message, which expands to
the complete path name of the source file within the kernel tree.

With the following patch, when used in a module, they'll insert the
module name instead, which is significantly shorter and also tends to
be more useful to users trying to make sense of a particular message.

Signed-off-by: Tilman Schmidt <tilman@imap.cc>
---

 usb.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff -ru linux-2.6.16-rc4-mm1-orig/include/linux/usb.h linux-2.6.16-rc4-patch-splitpoint/include/linux/usb.h
--- linux-2.6.16-rc4-mm1-orig/include/linux/usb.h	2006-02-22 12:04:07.000000000 +0100
+++ linux-2.6.16-rc4-patch-splitpoint/include/linux/usb.h	2006-02-24 10:37:53.000000000 +0100
@@ -1211,11 +1211,11 @@
 #endif

 #define err(format, arg...) printk(KERN_ERR "%s: " format "\n" , \
-	__FILE__ , ## arg)
+	THIS_MODULE ? THIS_MODULE->name : __FILE__ , ## arg)
 #define info(format, arg...) printk(KERN_INFO "%s: " format "\n" , \
-	__FILE__ , ## arg)
+	THIS_MODULE ? THIS_MODULE->name : __FILE__ , ## arg)
 #define warn(format, arg...) printk(KERN_WARNING "%s: " format "\n" , \
-	__FILE__ , ## arg)
+	THIS_MODULE ? THIS_MODULE->name : __FILE__ , ## arg)


 #endif  /* __KERNEL__ */

--
Tilman Schmidt                          E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)




[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]

             reply	other threads:[~2006-02-24  9:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-24  9:50 Tilman Schmidt [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-02-23 23:10 [PATCH] reduce syslog clutter Tilman Schmidt
2006-02-24  6:05 ` Greg KH
2006-02-24  9:29   ` Tilman Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43FED6FC.3090604@imap.cc \
    --to=tilman@imap.cc \
    --cc=hjlipp@web.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.