From: Hannes Reinecke <hare@suse.de>
To: Karan Tilak Kumar <kartilak@cisco.com>, sebaddel@cisco.com
Cc: arulponn@cisco.com, djhawar@cisco.com, gcboffa@cisco.com,
mkai2@cisco.com, satishkh@cisco.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/14] scsi: fnic: Add and integrate support for FIP
Date: Wed, 12 Jun 2024 08:47:56 +0200 [thread overview]
Message-ID: <43b8bd73-efca-45b0-9526-3c19c8cb3713@suse.de> (raw)
In-Reply-To: <20240610215100.673158-8-kartilak@cisco.com>
On 6/10/24 23:50, Karan Tilak Kumar wrote:
> Add and integrate support for FCoE Initialization
> (protocol) FIP. This protocol will be exercised on
> Cisco UCS rack servers.
> Add support to specifically print FIP related
> debug messages.
> Replace existing definitions to handle new
> data structures.
> Clean up old and obsolete definitions.
>
Aren't you getting a bit overboard here?
I am _positive_ that the original fnic driver _did_ do FIP.
What happened to that?
Why can't you just use that implementation?
And if you can't use that implementation, shouldn't this rather be
a new driver instead of replacing most if not all functionality of
the original fnic driver?
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
next prev parent reply other threads:[~2024-06-12 6:47 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 21:50 [PATCH 00/14] Introduce support for feature Fabric Discovery and Karan Tilak Kumar
2024-06-10 21:50 ` [PATCH 01/14] scsi: fnic: Replace shost_printk with pr_info/pr_err Karan Tilak Kumar
2024-06-11 6:32 ` Hannes Reinecke
2024-06-12 22:25 ` Karan Tilak Kumar (kartilak)
2024-06-10 21:50 ` [PATCH 02/14] scsi: fnic: Add headers and definitions for FDLS Karan Tilak Kumar
2024-06-11 6:53 ` Hannes Reinecke
2024-06-12 22:48 ` Karan Tilak Kumar (kartilak)
2024-06-10 21:50 ` [PATCH 03/14] scsi: fnic: Add support for fabric based solicited requests and responses Karan Tilak Kumar
2024-06-11 7:09 ` Hannes Reinecke
2024-06-17 19:36 ` Karan Tilak Kumar (kartilak)
2024-06-11 16:12 ` kernel test robot
2024-06-11 18:38 ` kernel test robot
2024-06-10 21:50 ` [PATCH 04/14] scsi: fnic: Add support for target " Karan Tilak Kumar
2024-06-11 13:31 ` Hannes Reinecke
2024-06-11 17:48 ` Karan Tilak Kumar (kartilak)
2024-06-26 10:01 ` Karan Tilak Kumar (kartilak)
2024-06-11 17:56 ` kernel test robot
2024-06-10 21:50 ` [PATCH 05/14] scsi: fnic: Add support for unsolicited " Karan Tilak Kumar
2024-06-12 6:31 ` Hannes Reinecke
2024-06-26 9:46 ` Karan Tilak Kumar (kartilak)
2024-06-10 21:50 ` [PATCH 06/14] scsi: fnic: Add and integrate support for FDMI Karan Tilak Kumar
2024-06-10 23:18 ` kernel test robot
2024-06-12 6:45 ` Hannes Reinecke
2024-06-18 17:50 ` Karan Tilak Kumar (kartilak)
2024-06-10 21:50 ` [PATCH 07/14] scsi: fnic: Add and integrate support for FIP Karan Tilak Kumar
2024-06-12 6:47 ` Hannes Reinecke [this message]
2024-06-15 3:44 ` Karan Tilak Kumar (kartilak)
2024-06-15 9:05 ` Hannes Reinecke
2024-06-17 18:56 ` Karan Tilak Kumar (kartilak)
2024-06-13 15:46 ` John Garry
2024-06-18 20:37 ` Karan Tilak Kumar (kartilak)
2024-08-09 16:36 ` Karan Tilak Kumar (kartilak)
2024-06-10 21:50 ` [PATCH 08/14] scsi: fnic: Add functionality in fnic to support FDLS Karan Tilak Kumar
2024-06-12 6:57 ` Hannes Reinecke
2024-06-15 3:47 ` Karan Tilak Kumar (kartilak)
2024-06-15 9:07 ` Hannes Reinecke
2024-06-17 19:25 ` Karan Tilak Kumar (kartilak)
2024-06-10 21:50 ` [PATCH 09/14] scsi: fnic: Modify IO path to use FDLS Karan Tilak Kumar
2024-06-12 7:18 ` Hannes Reinecke
2024-06-18 17:36 ` Karan Tilak Kumar (kartilak)
2024-06-10 21:50 ` [PATCH 10/14] scsi: fnic: Modify fnic interfaces " Karan Tilak Kumar
2024-06-10 21:50 ` [PATCH 11/14] scsi: fnic: Add stats and related functionality Karan Tilak Kumar
2024-06-10 21:50 ` [PATCH 12/14] scsi: fnic: Code cleanup Karan Tilak Kumar
2024-06-10 21:50 ` [PATCH 13/14] scsi: fnic: Add support to handle port channel RSCN Karan Tilak Kumar
2024-06-10 21:51 ` [PATCH 14/14] scsi: fnic: Increment driver version Karan Tilak Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43b8bd73-efca-45b0-9526-3c19c8cb3713@suse.de \
--to=hare@suse.de \
--cc=arulponn@cisco.com \
--cc=djhawar@cisco.com \
--cc=gcboffa@cisco.com \
--cc=jejb@linux.ibm.com \
--cc=kartilak@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mkai2@cisco.com \
--cc=satishkh@cisco.com \
--cc=sebaddel@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.