All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Lutz Lengemann" <lutz@lengemann.net>
To: "D. Ben Knoble" <ben.knoble@gmail.com>
Cc: "Lutz Lengemann" <gitgitgadget@gmail.com>,
	git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH] completion: zsh: support completion after "git -C <path>"
Date: Tue, 18 Aug 2026 14:40:47 +0200	[thread overview]
Message-ID: <43bc34ae-451d-4270-84a6-bbbf8de80115@app.fastmail.com> (raw)
In-Reply-To: <CALnO6CCWADaQycF7XcCFLDgCVtkTAsndKykAWzNhPqVAKWYGzA@mail.gmail.com>

Hi

On Tue, Aug 18, 2026, at 14:13, D. Ben Knoble wrote:
> No worries! Hope you enjoyed. (I didn't see v2 come in anywhere, but
> I'll keep my eye out.)

I pushed the new change to my github repo, and then the PullRequest here was 
updated: https://github.com/gitgitgadget/git/pull/2155/changes

> > and --git-dir and friends are spelled "--git-dir=-", which
> > accepts only "--git-dir=<path>", not the "--git-dir <path>" form.  I can
> > send patches for those separately.
> 
> We were discussing this recently in some threads about Bash
> completion, and I think we landed on "gitcli(1) really prefers the
> stuck form, and so do completion helpers, so let's stick with that for
> now" ?

Ok, sound good.

> > I tried that and it works, but it changes what -C offers, which is more
> > than fixing the completion after -C, so I left it out; happy to send it
> > on top.  Two things to watch out for there: the accumulated path has to
> > be made absolute, as -W with ".." gave me the directories of "/", and
> > the accumulation has to stop before the word that is being completed.
> 
> A follow-up is fine with me if you decide to send it (and if not,
> that's fine, too).

Lets see if Ican find the time for that ;)

Would really love to see the change in git, makes me a bit proud that I 
added something to the one application almost all developers use.

Regards

Lutz

  reply	other threads:[~2026-08-18 12:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-17 15:30 [PATCH] completion: zsh: support completion after "git -C <path>" Lutz Lengemann via GitGitGadget
2026-06-17 17:17 ` Ben Knoble
2026-06-17 17:21 ` Junio C Hamano
2026-06-18 17:43 ` D. Ben Knoble
2026-07-14 22:34   ` D. Ben Knoble
2026-08-17 19:29     ` Lutz Lengemann
2026-08-18 12:13       ` D. Ben Knoble
2026-08-18 12:40         ` Lutz Lengemann [this message]
2026-08-18 16:35           ` D. Ben Knoble
2026-08-19 13:07 ` [PATCH v2] " Lutz Lengemann via GitGitGadget
2026-08-20 12:28   ` D. Ben Knoble
2026-08-20 21:39     ` Junio C Hamano
2026-08-21 12:31       ` D. Ben Knoble
2026-08-21 16:42         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43bc34ae-451d-4270-84a6-bbbf8de80115@app.fastmail.com \
    --to=lutz@lengemann.net \
    --cc=ben.knoble@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.