From: Jeuk Kim <jeuk20.kim@gmail.com>
To: Ilia Levi <ilia.levi@intel.com>, qemu-devel@nongnu.org
Cc: jeuk20.kim@samsung.com, farosas@suse.de, lvivier@redhat.com,
pbonzini@redhat.com
Subject: Re: [PATCH 0/2] hw/ufs: Fix mcq completion queue wraparound
Date: Fri, 2 Jan 2026 09:07:57 +0900 [thread overview]
Message-ID: <43c7dfcf-9b5e-4d2c-89a7-339fb147df12@gmail.com> (raw)
In-Reply-To: <20251222123559.3387-1-ilia.levi@intel.com>
On 12/22/2025 9:35 PM, Ilia Levi wrote:
> Currently the completion queue processing routine in UFS does not check
> whether there is available space. This can cause CQ entries to be discarded
> and overwritten. This series include a fix for the issue based on how NVMe
> processes completions. It also includes a test to illustrate the issue.
>
> Before applying the fix, the test will fail with:
> ERROR:../tests/qtest/ufs-test.c:801:ufstest_mcq_cq_wraparound:
> assertion failed (completed == num_requests): (0 == 32)
>
> Ilia Levi (2):
> hw/ufs: Fix mcq completion queue wraparound
> tests/qtest/ufs-test: Add test for mcq completion queue wraparound
>
> hw/ufs/ufs.c | 20 ++++++-
> hw/ufs/ufs.h | 9 +++
> tests/qtest/ufs-test.c | 125 +++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 153 insertions(+), 1 deletion(-)
Hi Ilia,
Sorry for the late reply. Thanks a lot for the fix and the test.
Reviewed-by: Jeuk Kim <jeuk20.kim@samsung.com>
prev parent reply other threads:[~2026-01-02 0:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-22 12:35 [PATCH 0/2] hw/ufs: Fix mcq completion queue wraparound Ilia Levi
2025-12-22 12:35 ` [PATCH 1/2] " Ilia Levi
2025-12-22 12:35 ` [PATCH 2/2] tests/qtest/ufs-test: Add test for " Ilia Levi
2026-01-02 13:38 ` Fabiano Rosas
2026-01-02 0:07 ` Jeuk Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43c7dfcf-9b5e-4d2c-89a7-339fb147df12@gmail.com \
--to=jeuk20.kim@gmail.com \
--cc=farosas@suse.de \
--cc=ilia.levi@intel.com \
--cc=jeuk20.kim@samsung.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.