From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A25CC4338F for ; Wed, 4 Aug 2021 06:47:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0EBBC60F35 for ; Wed, 4 Aug 2021 06:47:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235668AbhHDGrX (ORCPT ); Wed, 4 Aug 2021 02:47:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235019AbhHDGrW (ORCPT ); Wed, 4 Aug 2021 02:47:22 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92188C0613D5 for ; Tue, 3 Aug 2021 23:47:10 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id x8so2738488lfe.3 for ; Tue, 03 Aug 2021 23:47:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4L5C9qrfvxf2bLH/dJuxNea8Tx+I1a3YCfc9PAs4P7U=; b=Il/VCEqYlC6ksvcMadJhlPAmuN3qhS2Lt4yyz2/kXEqvxXrLwdykT1Gx2LRuqStLPn DtMKhXob1sGbHw8m0B4DjsfKi2LpFcURW6JuroRHTLQ2sJbbH4wKeje7S1c2iipCRjmO k09aO5mNKEO9a+UvI/YZP4gDlUhfS8xLyD6xR3JIyWaD2W5PW1L1w2LUJjy7DnNdNQbb x4myEr65cZQhnHZB3Qae7yG1V8PnLnAw1+6RsleeM+PFzvVfl9NBlMyHooMyyzeDRUyy LIvHZqpkLmidUTyLR3rsj6xaUNA/LLcBhrHckGrpTyIEc6iB/nN9ADEzEqgW21YCqWaN WBrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4L5C9qrfvxf2bLH/dJuxNea8Tx+I1a3YCfc9PAs4P7U=; b=PGcPZJhvCIciHtQW4Mv1Oo0U67BWhTcUycgaoLidIXeabPvJF66IM36Nf2myyTjs4N 672C//zsTx2mPH/tA5hGKSOQA3SWWnpf60rFDkrd/4qGRmOx1iM90iuHvY4dvajLyZ6N EMYJnYfunBn2m0Hg67WWi/9Ptk/bi3GCK1x3jX1f0/LdLgd0rZkK58RSE8o9oMzaecP/ VBfp464udcKmOQFCMrP8wvo1RRRY+1z6uYgg4fhZegmTKexkJProUcuioY1bQSBgtMxV jQTLNTh9oXSe8qqzegC/U6Ck1BgHMMpJxkCNPyjdZUaRmil4MYUF3aTeBcwr4hgpCODJ LmfA== X-Gm-Message-State: AOAM5310nUjQ2G6dUjKbWe8fB/5lOwAuLqx5QK+DjOtTXNIM+urWrrAa EVObrSWxNQetW9EzXtLfLEc3OfhpOXRMhg== X-Google-Smtp-Source: ABdhPJxi11SfTIBDXlBAjy5KtHRdUDtJ0ibrwT78Sx7PJjwGirhoi3cGr/5LtfStPPFEFbG63rnSVw== X-Received: by 2002:a05:6512:318d:: with SMTP id i13mr840978lfe.627.1628059628978; Tue, 03 Aug 2021 23:47:08 -0700 (PDT) Received: from localhost.localdomain (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.googlemail.com with ESMTPSA id j6sm105858lfg.186.2021.08.03.23.47.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Aug 2021 23:47:08 -0700 (PDT) Subject: Re: [PATCH 1/2] PCI: of: Don't fail devm_pci_alloc_host_bridge() on missing 'ranges' To: Rob Herring Cc: linux-pci@vger.kernel.org, Srinath Mannam , Roman Bacik , Bharat Gooty , Abhishek Shah , Jitendra Bhivare , Ray Jui , Florian Fainelli , BCM Kernel Feedback , Scott Branden , Bjorn Helgaas , Lorenzo Pieralisi References: <20210803215656.3803204-1-robh@kernel.org> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Message-ID: <43cf8f88-dd3f-5060-d300-4deb95dc371c@gmail.com> Date: Wed, 4 Aug 2021 08:47:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210803215656.3803204-1-robh@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 03.08.2021 23:56, Rob Herring wrote: > Commit 669cbc708122 ("PCI: Move DT resource setup into > devm_pci_alloc_host_bridge()") made devm_pci_alloc_host_bridge() fail on > any DT resource parsing errors, but Broadcom iProc uses > devm_pci_alloc_host_bridge() on BCMA bus devices that don't have DT > resources. In particular, there is no 'ranges' property. Fix iProc by > making 'ranges' optional. > > If 'ranges' is required by a platform, there's going to be more errors > latter on if it is missing. > > Fixes: 669cbc708122 ("PCI: Move DT resource setup into devm_pci_alloc_host_bridge()") > Reported-by: Rafał Miłecki > Cc: Srinath Mannam > Cc: Roman Bacik > Cc: Bharat Gooty > Cc: Abhishek Shah > Cc: Jitendra Bhivare > Cc: Ray Jui > Cc: Florian Fainelli > Cc: BCM Kernel Feedback > Cc: Scott Branden > Cc: Bjorn Helgaas > Cc: Lorenzo Pieralisi > Signed-off-by: Rob Herring You're great Rob, thank you! I've tested it on top of the 669cbc708122 and linux-5.10.y. Tested-by: Rafał Miłecki