From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0DD3C3ABC0 for ; Wed, 7 May 2025 07:38:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:References:To:MIME-Version:Date: Message-ID:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=o6Nj2mt0cb1hDtjR1kjdSQHFXTAfVtuWiV9zBgixo4w=; b=TmuLWZXn5Z18hf1iJM8K4hjJYQ J64gPIGBbsKI6yzYtVkaVeqvOlDDPw0/JlWOuP04C8zxh1b6/mj7Duf5m3lhJogTwzu9cS7SW3Qus iKPDvi9VurpRUdx6lHpSv8afQgEH/4ZmJy5yZFvIKfV61RB6aKZDbmCGoO5fJQOhj2M0=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1uCZMj-0005ih-FP; Wed, 07 May 2025 07:38:53 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uCZMi-0005iY-MX for linux-f2fs-devel@lists.sourceforge.net; Wed, 07 May 2025 07:38:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:To:Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ndvVvqzW02iDMlSVq1UhwKyoVbRbz+prEu0cTgjgUNA=; b=fGYyEllK9sdra3/hp27VScxutw 0wdnW2xaoGTwJKjx8CBoF0vrYsjrWZBQ8X7FnlmrklI6aIRux4Qjjpm+V2jBmIvieg026ch4Tgr88 eCoD85VxOw9lkaYrlbNBoXKDDEuK2LFJYcAGKtd+k+NgB4g2mnbvER9Var+gsy2xevvQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:To: Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ndvVvqzW02iDMlSVq1UhwKyoVbRbz+prEu0cTgjgUNA=; b=EhQFEbNa+GPBw0BnNqcNx+osjU QoVlaxv/jKnrVgQvuuB1B26TUMB9C1QkTvWh0uDHQu9IWrirAtz+GI8/CoivhUHOWPAVdH50YU++q NjjZsTM4ITku9toTwnMusNyLQ+rT9LkAYtg6lZXC87OKwA6DM1RQvsfu6l2RRma4Weho=; Received: from sea.source.kernel.org ([172.234.252.31]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1uCZMT-0003J5-2A for linux-f2fs-devel@lists.sourceforge.net; Wed, 07 May 2025 07:38:52 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 8977649DC0; Wed, 7 May 2025 07:38:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E141C4CEE7; Wed, 7 May 2025 07:38:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746603506; bh=OQNVDW+Or51VukOrXMnIsaIqPxIvjVsqNhnia7ZvKKU=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=lX9kRX+f3tNfG8qYW8VH+Zmoaez5JKKR5ZaBYAHAXZo1zIeU1h3VGqXsvwPjYt8NU H+3c0ICicoGJ3VjmkwHv+bkFKHwMOUmJEZ5IcB6hOe5+YuuAzSQX/+TZQ1C9qbd+eN YPZLWxi3pTFbsbHEd+doTFDrko51eJ4w0nPf2+nXXnSyjhiSogQtWgwFZP6Poxldnj NY+uqnxVeyyKn/JA5P2gUW1dFeycXonduN3APHznzlO9tJ7Rgd8OyJryNacKr+hvED /5wvyIzXFfdM5OnnQP33/6fxW7gDhyPdau7fqCvJ3ei1wcZmhpi6HVfPDXJ5havIMa AupA2pZfwgSPw== Message-ID: <43d55ab4-c490-4f3d-8331-dc47f427d06d@kernel.org> Date: Wed, 7 May 2025 15:38:20 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Christoph Hellwig , Jaegeuk Kim References: <20250505092613.3451524-1-hch@lst.de> Content-Language: en-US In-Reply-To: <20250505092613.3451524-1-hch@lst.de> X-Headers-End: 1uCZMT-0003J5-2A Subject: Re: [f2fs-dev] cleanup AOP_WRITEPAGE_ACTIVATE use in f2fs X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Chao Yu via Linux-f2fs-devel Reply-To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 5/5/25 17:25, Christoph Hellwig wrote: > Hi all, > > this almost entirely cleans up usage of AOP_WRITEPAGE_ACTIVATE in f2fs. > > f2fs_sync_node_pages can still return it in a way that is not handled > by any caller and eventually is propagated to userspace. This does look > like a bug and needs attention by someone who actually knows the code. Oh, I guess this is a bug, thanks for catching this. Anyway, let me fix this based on your patchset. Thanks, > > Diffstat: > checkpoint.c | 22 +++++++++++----------- > compress.c | 5 +---- > data.c | 13 ++++--------- > node.c | 43 ++++++++++++++++++++----------------------- > 4 files changed, 36 insertions(+), 47 deletions(-) _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BBAD17A2E3 for ; Wed, 7 May 2025 07:38:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746603507; cv=none; b=qqP5A9BUUjlSdCzA1TYCZ1ulsagC6EK+eLmH9DSLMhifIrdDf289BeIadtscvSWOhH/e/CSNHNCPp0tVn0ptMyFKNJ7oQNcpft+aDgDVm26c7lChdGpEenK/o3tJIc6JR/tThRnhXLYKdYc1lWNxCy+pBlFzDyAUtqZ1TZDJdEY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746603507; c=relaxed/simple; bh=OQNVDW+Or51VukOrXMnIsaIqPxIvjVsqNhnia7ZvKKU=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=eIwJxyfZl5uFE6Unhdb+t653zFrDpXE+/A7C9sslLCobdhfbJ+tf3kljDESZGydJrJc8FmjAR2H59gHDH+WsEg2U4x55bf1/vmSrqWtWqKEd9NZNQz5XmxwALzltLbrqLCqLymDnRX0IW2MIOYSCnBihk5zOlSc3JzNnCkkxgu8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lX9kRX+f; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lX9kRX+f" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E141C4CEE7; Wed, 7 May 2025 07:38:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746603506; bh=OQNVDW+Or51VukOrXMnIsaIqPxIvjVsqNhnia7ZvKKU=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=lX9kRX+f3tNfG8qYW8VH+Zmoaez5JKKR5ZaBYAHAXZo1zIeU1h3VGqXsvwPjYt8NU H+3c0ICicoGJ3VjmkwHv+bkFKHwMOUmJEZ5IcB6hOe5+YuuAzSQX/+TZQ1C9qbd+eN YPZLWxi3pTFbsbHEd+doTFDrko51eJ4w0nPf2+nXXnSyjhiSogQtWgwFZP6Poxldnj NY+uqnxVeyyKn/JA5P2gUW1dFeycXonduN3APHznzlO9tJ7Rgd8OyJryNacKr+hvED /5wvyIzXFfdM5OnnQP33/6fxW7gDhyPdau7fqCvJ3ei1wcZmhpi6HVfPDXJ5havIMa AupA2pZfwgSPw== Message-ID: <43d55ab4-c490-4f3d-8331-dc47f427d06d@kernel.org> Date: Wed, 7 May 2025 15:38:20 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: cleanup AOP_WRITEPAGE_ACTIVATE use in f2fs To: Christoph Hellwig , Jaegeuk Kim References: <20250505092613.3451524-1-hch@lst.de> Content-Language: en-US From: Chao Yu In-Reply-To: <20250505092613.3451524-1-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/5/25 17:25, Christoph Hellwig wrote: > Hi all, > > this almost entirely cleans up usage of AOP_WRITEPAGE_ACTIVATE in f2fs. > > f2fs_sync_node_pages can still return it in a way that is not handled > by any caller and eventually is propagated to userspace. This does look > like a bug and needs attention by someone who actually knows the code. Oh, I guess this is a bug, thanks for catching this. Anyway, let me fix this based on your patchset. Thanks, > > Diffstat: > checkpoint.c | 22 +++++++++++----------- > compress.c | 5 +---- > data.c | 13 ++++--------- > node.c | 43 ++++++++++++++++++++----------------------- > 4 files changed, 36 insertions(+), 47 deletions(-)