From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0866518641; Tue, 5 Nov 2024 01:34:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730770470; cv=none; b=JdWjAMnznIv6Wfb9HDcLf3q5cfAqpVOwpO8rhAgM8gFZpUAE34N7eKgUIUeB3bn4kM1pKQ8pp/LTJA7JRNPlDtsUuRbot8k181h9D0ttnadbZFOU8mw544lC5KBo+YuBOvrE7nb8XRPunXElJdBmX/jYxoQEftiMc/R9aUj7Fzg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730770470; c=relaxed/simple; bh=pZqyeDU4Z0xb82ka1rqo9zPh5E+ZbwXvL5ApzcS2al4=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=BnS/eclFVmp4wRVyRxbcMa1U60UqDxS4JL6LqV1fIx5ckxUZdVtlcgITSy+0n9HhWyNhtgzkr9EaS0po4GNuyebFzVvnn/SqonjSYJtyd0bn/c0VG8005cCi2Opr2gfqJj+QMHgl7gFyv9zsyuNGkiH8H09SR1fRYT/M307uPtc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cilUS0qQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cilUS0qQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D0B7C4CECE; Tue, 5 Nov 2024 01:34:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730770469; bh=pZqyeDU4Z0xb82ka1rqo9zPh5E+ZbwXvL5ApzcS2al4=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=cilUS0qQCFaxNF3zH63qgUIqVpBsK5ZAO2+Mc4CrXmk6QZIa3ZA/1eyWd894pH2td p6DeOBI4b44PBAllxDSwZ+pvc/5OEkcYzKgLtcgnvluIpjNagN96SxdO1hq1RTBHL4 IsHQ3dUtDassq5aGIJOJqxs+MkAOhLYww1/sRgfew7akFKeqGOT8zYLFCTpqAtJETh hetvPOAoOKDF42PLByagmL9JEdRSFvR3DT2TRaUD4mTfYhVrokbWecXm5y2cdsb4O7 uykYoTN0CALyatfk7dtT2vPJ/mDxiOvw5DHvt59QcW4RICZcRPoNv9l/f+5h04HOGk wE3h4ii4bPJsw== Message-ID: <43d8b52e-5e5b-4a37-9a18-6ac392048d92@kernel.org> Date: Tue, 5 Nov 2024 09:34:23 +0800 Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Chao Yu , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, x86@kernel.org, linux-mips@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-crypto@vger.kernel.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, linux-ext4@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Subject: Re: [f2fs-dev] [PATCH v3 17/18] f2fs: switch to using the crc32 library To: Eric Biggers , linux-kernel@vger.kernel.org References: <20241103223154.136127-1-ebiggers@kernel.org> <20241103223154.136127-18-ebiggers@kernel.org> Content-Language: en-US From: Chao Yu In-Reply-To: <20241103223154.136127-18-ebiggers@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024/11/4 6:31, Eric Biggers via Linux-f2fs-devel wrote: > From: Eric Biggers > > Now that the crc32() library function takes advantage of > architecture-specific optimizations, it is unnecessary to go through the > crypto API. Just use crc32(). This is much simpler, and it improves > performance due to eliminating the crypto API overhead. > > Reviewed-by: Ard Biesheuvel > Signed-off-by: Eric Biggers Acked-by: Chao Yu Thanks, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1B6AD1CA0E for ; Tue, 5 Nov 2024 01:34:44 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1t88Sw-0001l4-4f; Tue, 05 Nov 2024 01:34:42 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1t88Sv-0001kx-CM for linux-f2fs-devel@lists.sourceforge.net; Tue, 05 Nov 2024 01:34:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:To:Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=NHOy9HMfGZsNYCZrwLCSvIFDt8NcrmF4jHCNX3GgtvM=; b=bcsta4BV00HJ4B4EdpAyg2xs9m 8HWz731h4lhi+eDyePWDbgb7EEWh+biNQKE3uW+FVHw7Y/iSP2Dp5O0gMGQjup4emiOvyww12oqIQ PQfs2FP0XqEwTxrv5zl1PsDDM3uScqKulk8Sz61Nc+7JTld4skOFmJ/Xj6Mb86WlwGR4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:To: Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=NHOy9HMfGZsNYCZrwLCSvIFDt8NcrmF4jHCNX3GgtvM=; b=Gta5M/uWFcbikDPfK2z6mCNSiI tnTZ0csMMqW13We9a4t5qLmay6Ndhxn+At7jaMarCo1CupILJzXc3OeohlYKmUM0zf3D4gNo+abNP /k71wLkFUAwPy7loUrv+SlX6dnaPEHQswc0jyefGvpnyLB567+DTAc3RHvoSN9wRsEnY=; Received: from nyc.source.kernel.org ([147.75.193.91]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1t88Su-0006HP-IL for linux-f2fs-devel@lists.sourceforge.net; Tue, 05 Nov 2024 01:34:41 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id BD667A41C59; Tue, 5 Nov 2024 01:32:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D0B7C4CECE; Tue, 5 Nov 2024 01:34:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730770469; bh=pZqyeDU4Z0xb82ka1rqo9zPh5E+ZbwXvL5ApzcS2al4=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=cilUS0qQCFaxNF3zH63qgUIqVpBsK5ZAO2+Mc4CrXmk6QZIa3ZA/1eyWd894pH2td p6DeOBI4b44PBAllxDSwZ+pvc/5OEkcYzKgLtcgnvluIpjNagN96SxdO1hq1RTBHL4 IsHQ3dUtDassq5aGIJOJqxs+MkAOhLYww1/sRgfew7akFKeqGOT8zYLFCTpqAtJETh hetvPOAoOKDF42PLByagmL9JEdRSFvR3DT2TRaUD4mTfYhVrokbWecXm5y2cdsb4O7 uykYoTN0CALyatfk7dtT2vPJ/mDxiOvw5DHvt59QcW4RICZcRPoNv9l/f+5h04HOGk wE3h4ii4bPJsw== Message-ID: <43d8b52e-5e5b-4a37-9a18-6ac392048d92@kernel.org> Date: Tue, 5 Nov 2024 09:34:23 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Eric Biggers , linux-kernel@vger.kernel.org References: <20241103223154.136127-1-ebiggers@kernel.org> <20241103223154.136127-18-ebiggers@kernel.org> Content-Language: en-US In-Reply-To: <20241103223154.136127-18-ebiggers@kernel.org> X-Headers-End: 1t88Su-0006HP-IL Subject: Re: [f2fs-dev] [PATCH v3 17/18] f2fs: switch to using the crc32 library X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Chao Yu via Linux-f2fs-devel Reply-To: Chao Yu Cc: linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, x86@kernel.org, linux-scsi@vger.kernel.org, linux-mips@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-crypto@vger.kernel.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, linux-ext4@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2024/11/4 6:31, Eric Biggers via Linux-f2fs-devel wrote: > From: Eric Biggers > > Now that the crc32() library function takes advantage of > architecture-specific optimizations, it is unnecessary to go through the > crypto API. Just use crc32(). This is much simpler, and it improves > performance due to eliminating the crypto API overhead. > > Reviewed-by: Ard Biesheuvel > Signed-off-by: Eric Biggers Acked-by: Chao Yu Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3018ED1CA13 for ; Tue, 5 Nov 2024 01:37:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:Cc: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=opFxkrXgMzqa29+F8lVTMCJAMeuCW9bvwh4K/Ptrv7k=; b=eI/TEXhPRorzAH bXSNZZCY9/P6zUdhHXFO5fPlfLOINh65m5qEDoQFKFwCRmdxIK4QVOV3FOSZpaK29AACm3j4s254M ClDFD3+tZmYNjY9eHcrzIv0WGWyc4+QoGbojaXZELK790zGQXpWySYPolwquDB6ii6IE1tQsQeJAv btYXCGdGDeBA8xrlvv8V9TVZSwBS4Sg/tsTez85wUp7rQ/ksZhkD4LH55ojQi271yu6pWc6Jc9wBh 2qFaymkOeTgCHDQpDBEGXZrfeLg5po7Pzp+s9z9TGVUIqLAnI7oYmY42r+R0v9Hjq7ulXTyHxc6Ij WxGoB5GruqbFB4AoSC3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t88Ve-0000000FaLy-3XUU; Tue, 05 Nov 2024 01:37:30 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t88Sl-0000000FZof-1i8R; Tue, 05 Nov 2024 01:34:32 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id BD667A41C59; Tue, 5 Nov 2024 01:32:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D0B7C4CECE; Tue, 5 Nov 2024 01:34:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730770469; bh=pZqyeDU4Z0xb82ka1rqo9zPh5E+ZbwXvL5ApzcS2al4=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=cilUS0qQCFaxNF3zH63qgUIqVpBsK5ZAO2+Mc4CrXmk6QZIa3ZA/1eyWd894pH2td p6DeOBI4b44PBAllxDSwZ+pvc/5OEkcYzKgLtcgnvluIpjNagN96SxdO1hq1RTBHL4 IsHQ3dUtDassq5aGIJOJqxs+MkAOhLYww1/sRgfew7akFKeqGOT8zYLFCTpqAtJETh hetvPOAoOKDF42PLByagmL9JEdRSFvR3DT2TRaUD4mTfYhVrokbWecXm5y2cdsb4O7 uykYoTN0CALyatfk7dtT2vPJ/mDxiOvw5DHvt59QcW4RICZcRPoNv9l/f+5h04HOGk wE3h4ii4bPJsw== Message-ID: <43d8b52e-5e5b-4a37-9a18-6ac392048d92@kernel.org> Date: Tue, 5 Nov 2024 09:34:23 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Chao Yu , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, x86@kernel.org, linux-mips@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-crypto@vger.kernel.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, linux-ext4@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Subject: Re: [f2fs-dev] [PATCH v3 17/18] f2fs: switch to using the crc32 library To: Eric Biggers , linux-kernel@vger.kernel.org References: <20241103223154.136127-1-ebiggers@kernel.org> <20241103223154.136127-18-ebiggers@kernel.org> Content-Language: en-US From: Chao Yu In-Reply-To: <20241103223154.136127-18-ebiggers@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241104_173431_547981_131D4B50 X-CRM114-Status: UNSURE ( 7.32 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 2024/11/4 6:31, Eric Biggers via Linux-f2fs-devel wrote: > From: Eric Biggers > > Now that the crc32() library function takes advantage of > architecture-specific optimizations, it is unnecessary to go through the > crypto API. Just use crc32(). This is much simpler, and it improves > performance due to eliminating the crypto API overhead. > > Reviewed-by: Ard Biesheuvel > Signed-off-by: Eric Biggers Acked-by: Chao Yu Thanks, _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv