From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C411EECAAD3 for ; Wed, 14 Sep 2022 15:19:09 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2946C84AF8; Wed, 14 Sep 2022 17:19:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1663168747; bh=TPgXt5M2GUfjj3UWHHj7hH4uH4IhO8UmpoznaNd8ddw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=vPHXhGtGYGQlD/0ZCP3VNowyJfXfmPGoJ8SQDKG7sy8UmAeH2IzbDXROLgfvXhptz wuQ7iV4hzjIHYjF2R4MUiaV4XBxmCuIOiE45o/JEJEIbgPevLn3x9aJ+NWDwPGYdCQ wgTV6b8eMBaAOm1mrkL3EGhBMF02MMWnJ0qDl4CjGozMw+eVkV5uPY+XyoeIGPa/8A Z7VqEpRAQ89RUk+UbPHQqE/m2PbDnhmfzXK149gml96vb2+tcvyhawRC4blNvqhd2m giMuqiGM2Yx+ZUmdCV5z+RuCndTiRToq73iP9nnysU/cHflOXdsoYynmDNuX0X3DUi Kst2aEakCOY7Q== Received: by phobos.denx.de (Postfix, from userid 109) id 8D14984AFA; Wed, 14 Sep 2022 17:19:04 +0200 (CEST) Received: from mout-u-204.mailbox.org (mout-u-204.mailbox.org [80.241.59.204]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D415E8460D for ; Wed, 14 Sep 2022 17:19:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-204.mailbox.org (Postfix) with ESMTPS id 4MSPBC6Chrz9sSp; Wed, 14 Sep 2022 17:18:59 +0200 (CEST) Message-ID: <43dfb1e4-06b0-5cf5-39af-276528457fb5@denx.de> Date: Wed, 14 Sep 2022 17:18:58 +0200 MIME-Version: 1.0 Subject: Re: [PATCH v6 0/8] Add support for cyclic function execution infrastruture Content-Language: en-US To: Tom Rini Cc: u-boot@lists.denx.de, awilliams@marvell.com, cchavva@marvell.com, sjg@chromium.org References: <20220902115754.1280789-1-sr@denx.de> <166316029537.384403.17041270748286061433.b4-ty@konsulko.com> <636e0e41-b5a0-36e0-bd19-d9435513a5d3@denx.de> <20220914144704.GS6993@bill-the-cat> From: Stefan Roese In-Reply-To: <20220914144704.GS6993@bill-the-cat> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4MSPBC6Chrz9sSp X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 14.09.22 16:47, Tom Rini wrote: > On Wed, Sep 14, 2022 at 04:29:36PM +0200, Stefan Roese wrote: >> On 14.09.22 14:58, Tom Rini wrote: >>> On Fri, 2 Sep 2022 13:57:46 +0200, Stefan Roese wrote: >>> >>>> This patchset adds the basic infrastructure to periodically execute >>>> code, e.g. all 100ms. Examples for such functions might be LED blinking >>>> etc. The functions that are hooked into this cyclic list should be >>>> small timewise as otherwise the execution of the other code that relies >>>> on a high frequent polling (e.g. UART rx char ready check) might be >>>> delayed too much. This patch also adds the Kconfig option >>>> CONFIG_CYCLIC_MAX_CPU_TIME_US, which configures the max allowed time >>>> for such a cyclic function. If it's execution time exceeds this time, >>>> this cyclic function will get removed from the cyclic list. >>>> >>>> [...] >>> >>> For the series, applied to u-boot/next, thanks! >> >> Thanks Tom. >> >> This patch series should not introduce any functional changes. The >> next one though, which migrates the WATCHDOG_RESET into the cyclic >> function execution IF needs a quite some testing. Perhaps it makes >> sense to pull this other series as well quite early in the release >> cycle, so that it receives a lot of "attention"? So that we have >> time to fix potential problems here. >> >> What do you think? > > Yes, the watchdog series should come to next, for v2023.01 as well. Are > you comfortable with it now, or are you planning to v2 it? I've only tested it on an MIPS Octeon platform so far. Where I am a bit hesitant is, the very early watchdog integration and SPL. This definitely needs some extensive testing. I don't have any platform for this here ready right now. Thanks, Stefan