Re: [PATCH 3/3] sata_sil: clean up and add errata/workaround documentation

[Jeff Garzik <jgarzik@pobox.com>]

Tejun Heo wrote:
> This patch collects into one place/update errata documentattion and
> adds description of 3114 R_ERR on DMA activate FIS errata.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> 
> ---
> 
>  drivers/scsi/sata_sil.c |   97 ++++++++++++++++++++++++++++++++++++-----------
>  1 files changed, 75 insertions(+), 22 deletions(-)
> 
> 6b1cc9dff33ae20157946ae8b06f1a11079b4af6
> diff --git a/drivers/scsi/sata_sil.c b/drivers/scsi/sata_sil.c
> index 9face3c..75784cd 100644
> --- a/drivers/scsi/sata_sil.c
> +++ b/drivers/scsi/sata_sil.c
> @@ -30,8 +30,79 @@
>   *  Documentation for SiI 3112:
>   *  http://gkernel.sourceforge.net/specs/sii/3112A_SiI-DS-0095-B2.pdf.bz2
>   *
> + *  Documentation for SiI 3114:
> + *  http://gkernel.sourceforge.net/specs/sii/sii-0680a-v1.31.pdf.bz2
> + *
>   *  Other errata and documentation available under NDA.

I'll apply patches 1-2.

For this patch #3, two comments:

* the above URL points to CMD680 docs, not 3114

* I'm unconvinced that long exposition should be in the .c file.  I 
think its far better to put it into Documentation/DocBook/libata.tmpl. 
I have some long term plans to add more hardware details to the docbook 
docs, infact.

	Jeff