All of lore.kernel.org
 help / color / mirror / Atom feed
From: "James (Alec) Burney" <madbull@gmail.com>
To: Alexander Zarochentsev <zam@namesys.com>
Cc: reiserfs-list@namesys.com
Subject: Re: possible reiser4 bug
Date: Sat, 25 Feb 2006 01:17:05 -1000	[thread overview]
Message-ID: <44003CB1.5050309@gmail.com> (raw)
In-Reply-To: <200602260009.36905.zam@namesys.com>

thanks for the patch, Alex, but yesterday i converted all of my
harddisks to reiserFS in an act of frustration. Sorry that i can't help
you test your patch.

Alexander Zarochentsev wrote:
> hello,
> 
> On Friday 24 February 2006 08:35, Alec Burney wrote:
> 
> [...]
> 
> 
> would you please try the attached patch.
> 
> 
> 
> ------------------------------------------------------------------------
> 
>  fs/reiser4/plugin/file/file.c |    9 +++++----
>  1 files changed, 5 insertions(+), 4 deletions(-)
> 
> Index: linux-2.6.16-rc3-mm1/fs/reiser4/plugin/file/file.c
> ===================================================================
> --- linux-2.6.16-rc3-mm1.orig/fs/reiser4/plugin/file/file.c
> +++ linux-2.6.16-rc3-mm1/fs/reiser4/plugin/file/file.c
> @@ -2454,6 +2454,7 @@ ssize_t write_unix_file(struct file *fil
>  
>  	if (inode_get_flag(inode, REISER4_PART_CONV)) {
>  		/* we can not currently write to a file which is partially converted */
> +		txn_restart(ctx);
>  		get_exclusive_access(uf_info);
>  		result = finish_conversion(inode);
>  		drop_exclusive_access(uf_info);
> @@ -2481,6 +2482,7 @@ ssize_t write_unix_file(struct file *fil
>  
>  		   3) convert file to extents to not enter here on each write
>  		   to mmaped file */
> +		txn_restart(ctx);
>  		get_exclusive_access(uf_info);
>  		result = check_pages_unix_file(file, inode);
>  		drop_exclusive_access(uf_info);
> @@ -2535,14 +2537,13 @@ ssize_t write_unix_file(struct file *fil
>  	while (left > 0) {
>  		int excl = 0;
>  
> -		/* getting exclusive or not exclusive access requires no
> -		   transaction open */
> -		txn_restart_current();
> -
>  		/* faultin user page */
>  		fault_in_pages_readable(buf,
>  					left > PAGE_CACHE_SIZE ? PAGE_CACHE_SIZE : left);
>  
> +		/* getting exclusive or not exclusive access requires no
> +		   transaction open */
> +		txn_restart(ctx);
>  		if (inode->i_size == 0) {
>  			get_exclusive_access(uf_info);
>  			excl = 1;

-- 
cell: 808.332.5131

  reply	other threads:[~2006-02-25 11:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-24  5:35 possible reiser4 bug Alec Burney
2006-02-25 21:09 ` Alexander Zarochentsev
2006-02-25 11:17   ` James (Alec) Burney [this message]
2006-02-26  2:33   ` Francesco Biscani
2006-02-26  7:33     ` Alexander Zarochentsev
2006-02-28 13:46       ` Francesco Biscani
  -- strict thread matches above, loose matches on Subject: below --
2006-03-10 19:51 Maarten Deprez, maartendeprez, maartendeprez, maartendeprez, maartendeprez, maartendeprez, maartendeprez, maartendeprez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44003CB1.5050309@gmail.com \
    --to=madbull@gmail.com \
    --cc=reiserfs-list@namesys.com \
    --cc=zam@namesys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.