[KJ] linux-2.6.15.4/drivers/i2c/i2c-core.c.bak: EPERM -> EINVAL

[KJ] linux-2.6.15.4/drivers/i2c/i2c-core.c.bak: EPERM -> EINVAL

[walter harms]

Hi list,
it was noticed that some driver return EPERM instead of EINVAL.
EPERM indicates no enought privilege to access a function.
This will fixit an return (i hope) a 'better' error msg.

re,
  walter


Signed-off-by: walter harms <wharms@bfs.de>

--- linux-2.6.15.4/drivers/i2c/i2c-core.c.bak	2006-02-25 
13:25:48.000000000 +0100
+++ linux-2.6.15.4/drivers/i2c/i2c-core.c	2006-02-25 13:24:44.000000000 
+0100
@@ -522,7 +522,7 @@
  		else {
  			pr_debug("i2c-core: %s used one too many times\n",
  				__FUNCTION__);
-			return -EPERM;
+			return -EINVAL;
  		}
  	}
  	
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] linux-2.6.15.4/drivers/i2c/i2c-core.c.bak: EPERM -> EINVAL

[Tim Cooijmans]

On Saturday 25 February 2006 13:30, walter harms wrote:
>   			pr_debug("i2c-core: %s used one too many times\n",
>   				__FUNCTION__);
> -			return -EPERM;
> +			return -EINVAL;
I think EBUSY would be more apprioriate here.  I'm not sure, though.  
include/asm-generic/errno-base.h has a short description for each errno.

Tim
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] linux-2.6.15.4/drivers/i2c/i2c-core.c.bak: EPERM -> EINVAL

[walter harms]

hi all,
imho EBUSY would indicate someone else is using it. But < 0 should never 
happen (integer overflow ?). even BUG() would be ok but the author 
decided otherwise and i do not what to change that.

re,
  walter

tim: do you know this ?
http://dev1.boomersdomain.com/cgi-bin/store_pedalinghistory_2/01068.html


Tim Cooijmans wrote:
> On Saturday 25 February 2006 13:30, walter harms wrote:
>>   			pr_debug("i2c-core: %s used one too many times\n",
>>   				__FUNCTION__);
>> -			return -EPERM;
>> +			return -EINVAL;
> I think EBUSY would be more apprioriate here.  I'm not sure, though.  
> include/asm-generic/errno-base.h has a short description for each errno.
> 
> Tim
> 
> 
> 
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] linux-2.6.15.4/drivers/i2c/i2c-core.c.bak: EPERM -> EINVAL

[Tim Cooijmans]

On Saturday 25 February 2006 14:06, walter harms wrote:
> hi all,
> imho EBUSY would indicate someone else is using it. But < 0 should never
> happen (integer overflow ?). even BUG() would be ok but the author
> decided otherwise and i do not what to change that.
Oh wait, I thought the function would try to set something up and fail at 
that.  Didn't see it was only trying to release stuff.

> tim: do you know this ?
> http://dev1.boomersdomain.com/cgi-bin/store_pedalinghistory_2/01068.html
Hahahaha, yes, that does look familiar.

Tim
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors