[KJ] Duplicated request_region code in arch/powerpc and arch/ppc

[KJ] Duplicated request_region code in arch/powerpc and arch/ppc

[Tim Cooijmans]

[-- Attachment #1: Type: text/plain, Size: 494 bytes --]

These files all request the same regions, namely dma1, dma2, dma page reg, 
pic1, pic2 and timer:

arch/powerpc/platforms/chrp/setup.c
arch/powerpc/platforms/pseries/pci.c
arch/ppc/platforms/chrp_setup.c
arch/ppc/platforms/lopec.c
arch/ppc/platforms/mvme5100.c
arch/ppc/platforms/pplus.c
arch/ppc/platforms/sandpoint.c

Should these requests be moved to a central function?  If so, what should the 
function be called (i.e., why are the regions requested) and where should it 
be defined?

Tim

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] Duplicated request_region code in arch/powerpc and arch/ppc

[walter harms]

hi tim,
chrp means "Common Hardware Reference Platform" therefore several boards 
can be exspected to have same design. I would add this as 
default_chrp_setup() into chrp_setup.c.

just my 2 cents,
re, walter


Tim Cooijmans wrote:
> These files all request the same regions, namely dma1, dma2, dma page reg, 
> pic1, pic2 and timer:
> 
> arch/powerpc/platforms/chrp/setup.c
> arch/powerpc/platforms/pseries/pci.c
> arch/ppc/platforms/chrp_setup.c
> arch/ppc/platforms/lopec.c
> arch/ppc/platforms/mvme5100.c
> arch/ppc/platforms/pplus.c
> arch/ppc/platforms/sandpoint.c
> 
> Should these requests be moved to a central function?  If so, what should the 
> function be called (i.e., why are the regions requested) and where should it 
> be defined?
> 
> Tim
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.osdl.org
> https://lists.osdl.org/mailman/listinfo/kernel-janitors
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors