All of lore.kernel.org
 help / color / mirror / Atom feed
From: walter harms <wharms@bfs.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] linux-2.6.15.4/drivers/i2c/i2c-core.c.bak:  EPERM -> EINVAL
Date: Sat, 25 Feb 2006 13:06:53 +0000	[thread overview]
Message-ID: <4400566D.4040101@bfs.de> (raw)
In-Reply-To: <44004DD8.2040606@bfs.de>

hi all,
imho EBUSY would indicate someone else is using it. But < 0 should never 
happen (integer overflow ?). even BUG() would be ok but the author 
decided otherwise and i do not what to change that.

re,
  walter

tim: do you know this ?
http://dev1.boomersdomain.com/cgi-bin/store_pedalinghistory_2/01068.html


Tim Cooijmans wrote:
> On Saturday 25 February 2006 13:30, walter harms wrote:
>>   			pr_debug("i2c-core: %s used one too many times\n",
>>   				__FUNCTION__);
>> -			return -EPERM;
>> +			return -EINVAL;
> I think EBUSY would be more apprioriate here.  I'm not sure, though.  
> include/asm-generic/errno-base.h has a short description for each errno.
> 
> Tim
> 
> 
> 
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2006-02-25 13:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-25 12:30 [KJ] linux-2.6.15.4/drivers/i2c/i2c-core.c.bak: EPERM -> EINVAL walter harms
2006-02-25 12:41 ` Tim Cooijmans
2006-02-25 13:06 ` walter harms [this message]
2006-02-25 13:50 ` Tim Cooijmans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4400566D.4040101@bfs.de \
    --to=wharms@bfs.de \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.