From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregor Maier Subject: Re: [NETFILTER 06/6]: Restore {ipt,ip6t,ebt}_LOG compatibility Date: Sat, 25 Feb 2006 15:13:17 +0100 Message-ID: <440065FD.5020206@net.in.tum.de> References: <20060225131547.7400.12127.sendpatchset@localhost.localdomain> <20060225131707.7400.26631.sendpatchset@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: netfilter-devel@lists.netfilter.org, davem@davemloft.net Return-path: To: Patrick McHardy In-Reply-To: <20060225131707.7400.26631.sendpatchset@localhost.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netfilter-devel.vger.kernel.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Patrick McHardy wrote: > [NETFILTER]: Restore {ipt,ip6t,ebt}_LOG compatibility > Restore compatiblity by using the old log functions by default and only use > the nf_log backend if the user explicitly said so. > ipt_LOG still registers itfself as nf_log logger in init(). Good, so since conntrack can now log. Problem: no anthoer loggers can register for PF_INET right away. They must unregister the ipt_LOG logger first. Then they can register themselves. I don't like the idea of modules and esp. userspace apps unregistering handlers from other modules. First Come First Serve. When ipt_LOG doesn't register a nf_log logger, then the problem would not arise, although the conntrack code could not log anything until some other logger has been registered (since conntrack uses nf_log_packet). Maybe nf_log should have two handlers for each PF: - - One handler for loginfo.type == NF_LOG_TYPE_LOG. Which can be provided by ipt_LOG. - - One handler for loginfo.type == NF_LOG_TYPE_ULOG, for which nfnetlink_log strongly qualifies. So, as long as ipt_LOG is loaded, conntrack et.al. can log to syslog as is. If netlink_log is used additionally, (as handler for TYPE_ULOG), conntrack et.al. won't notice it. If _everything_ should be logged to userspace, then netlink_log could also unregister the TYPE_LOG handler and register itself as handler for it. cu Gregor PS: Hope you don't mind that I make so much noise here on the list. - -- Gregor Maier Lehrstuhl Informatik 8 gregor@net.in.tum.de Tel: +49 89 289-18010 http://www.net.in.tum.de TU Muenchen -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (Darwin) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFEAGX9dGiwgbikMYMRAp7jAJ9ZZVVe2UWAybxqOA97GPHwy5/8TwCfR5nG kUDhWbnPadrpi9x2nTyNo2M= =LS7O -----END PGP SIGNATURE-----