All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zachary Amsden <zach@vmware.com>
To: Dave Jones <davej@redhat.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	ak@suse.de, dhecht@vmware.com, torvalds@osdl.org
Subject: Re: [PATCH] Fix topology.c location
Date: Sat, 25 Feb 2006 09:28:38 -0800	[thread overview]
Message-ID: <440093C6.4000904@vmware.com> (raw)
In-Reply-To: <20060225085538.GA17448@redhat.com>

Dave Jones wrote:

>This change breaks x86-64 compiles, as it uses the same file.
>  
>

Thanks for fixing that.  Have we decided that file sharing of this sort 
is a really bad idea yet?  I still see early_printk and  pci-direct.h 
sharing remains.  If this sharing really must go on, isn't there a less 
ad-hoc way to do it?  Or at least a mention in the file that "before you 
modify, note this is shared by arch foo".

Zach

  reply	other threads:[~2006-02-25 17:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200602242305.k1ON5Tmb026520@hera.kernel.org>
2006-02-25  8:55 ` [PATCH] Fix topology.c location Dave Jones
2006-02-25 17:28   ` Zachary Amsden [this message]
2006-02-25 18:09     ` Randy.Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=440093C6.4000904@vmware.com \
    --to=zach@vmware.com \
    --cc=ak@suse.de \
    --cc=davej@redhat.com \
    --cc=dhecht@vmware.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.