diff for duplicates of <4401360.Outsal0mcb@avalon> diff --git a/a/1.txt b/N1/1.txt index 87a2a56..67ed419 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,15 +3,15 @@ On Thursday 28 November 2013 21:11:48 Sergei Shtylyov wrote: > >> + #address-cells = <1>; > >> + #size-cells = <0>; > >> + -> >> + eeprom: 24c128@50 { +> >> + eeprom: 24c128 at 50 { > >> + compatible = "at,24c128"; > > > > Minor nit: Should be a vendor name, not the name of the driver > -> Moreover, the node should be named generically, like "flash@50", not -> "24c128@50". +> Moreover, the node should be named generically, like "flash at 50", not +> "24c128 at 50". -Or, given that it's an eeprom, "eeprom@50" ? :-) +Or, given that it's an eeprom, "eeprom at 50" ? :-) -- Regards, diff --git a/a/content_digest b/N1/content_digest index e3846ee..eab9757 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,9 +1,9 @@ "ref\020131127082736.20015.21303.sendpatchset@w520\0" "ref\020131127110413.GA2603@katana\0" "ref\052977954.20006@cogentembedded.com\0" - "From\0Laurent Pinchart <laurent.pinchart@ideasonboard.com>\0" - "Subject\0Re: [PATCH 03/04] ARM: shmobile: Genmai I2C-over-GPIO support\0" - "Date\0Thu, 28 Nov 2013 17:14:38 +0000\0" + "From\0laurent.pinchart@ideasonboard.com (Laurent Pinchart)\0" + "Subject\0[PATCH 03/04] ARM: shmobile: Genmai I2C-over-GPIO support\0" + "Date\0Thu, 28 Nov 2013 18:14:38 +0100\0" "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" @@ -12,19 +12,19 @@ "> >> +\t\t#address-cells = <1>;\n" "> >> +\t\t#size-cells = <0>;\n" "> >> +\n" - "> >> +\t\teeprom: 24c128@50 {\n" + "> >> +\t\teeprom: 24c128 at 50 {\n" "> >> +\t\t\tcompatible = \"at,24c128\";\n" "> > \n" "> > Minor nit: Should be a vendor name, not the name of the driver\n" "> \n" - "> Moreover, the node should be named generically, like \"flash@50\", not\n" - "> \"24c128@50\".\n" + "> Moreover, the node should be named generically, like \"flash at 50\", not\n" + "> \"24c128 at 50\".\n" "\n" - "Or, given that it's an eeprom, \"eeprom@50\" ? :-)\n" + "Or, given that it's an eeprom, \"eeprom at 50\" ? :-)\n" "\n" "-- \n" "Regards,\n" "\n" Laurent Pinchart -9ef2cb4f2efeac9dae6a5d646c8e56636658ee354f6391cc9eda31e924f6d1c3 +69756b9a577fb1ae473e1f590cfedc2b46e5396c66daf20925210a5d65350d8d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.