Re: [Xenomai-core] Re: [PATCH] Shared interrupts (ready to merge)

[Jan Kiszka <jan.kiszka@domain.hid>]

[-- Attachment #1: Type: text/plain, Size: 1098 bytes --]

Dmitry Adamushko wrote:
> ...
> This said, I'm going to publish the shirq patch (after finalizing ISR return
> bits,
> where I still have some doubts) without enable/disable nesting support.
> It can be supported at some point of time later, if it's really needed.
> 

Regarding enable/disable nesting and existing driver patterns: I
currently do the following on devices init via RTDM (and users may have
copied this):

rtdm_irq_request(...);
<init_hardware, also clear pending IRQs of the device>
rtdm_irq_enable(...);

But I do not disable the IRQ before rtdm_irq_free() again. Is this
unbalanced enabling still needed today? Is it even wrong these days? Is
it arch-dependent? I think the pattern dates back in RTAI times and was
needed for so far unused IRQs. Disabling them on device closure blocked
the line for later use under Linux.

I'm asking now in case we have to change the usage: we may better do it
early (e.g. with the introduction of Xenomai 2.1), so that the number of
surprises can be kept low when the underlying mechanisms get reworked later.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]