All of lore.kernel.org
 help / color / mirror / Atom feed
* [TRIVIAL] move PP_MAJOR from ppdev.h to major.h
@ 2006-02-26 23:09 Rene Herman
  0 siblings, 0 replies; only message in thread
From: Rene Herman @ 2006-02-26 23:09 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Linux Kernel

[-- Attachment #1: Type: text/plain, Size: 275 bytes --]

Hi Andrew.

Is this okay? Today I wondered about /dev/parport<n> after not seeing 
anything in drivers/parport register char-major-99. Having PP_MAJOR in 
include/linux/major.h would've allowed me to more quickly determine that 
it was the ppdev driver driving these.

Rene


[-- Attachment #2: ppdev_cleanup.diff --]
[-- Type: text/plain, Size: 1409 bytes --]

Index: local/drivers/char/ppdev.c
===================================================================
--- local.orig/drivers/char/ppdev.c	2006-01-03 04:21:10.000000000 +0100
+++ local/drivers/char/ppdev.c	2006-02-26 20:41:04.000000000 +0100
@@ -65,10 +65,11 @@
 #include <linux/parport.h>
 #include <linux/ctype.h>
 #include <linux/poll.h>
-#include <asm/uaccess.h>
+#include <linux/major.h>
 #include <linux/ppdev.h>
 #include <linux/smp_lock.h>
 #include <linux/device.h>
+#include <asm/uaccess.h>
 
 #define PP_VERSION "ppdev: user-space parallel port driver"
 #define CHRDEV "ppdev"
Index: local/include/linux/major.h
===================================================================
--- local.orig/include/linux/major.h	2006-01-03 04:21:10.000000000 +0100
+++ local/include/linux/major.h	2006-02-26 20:40:00.000000000 +0100
@@ -113,6 +113,7 @@
 
 #define UBD_MAJOR		98
 
+#define PP_MAJOR		99
 #define JSFD_MAJOR		99
 
 #define PHONE_MAJOR		100
Index: local/include/linux/ppdev.h
===================================================================
--- local.orig/include/linux/ppdev.h	2006-01-03 04:21:10.000000000 +0100
+++ local/include/linux/ppdev.h	2006-02-26 20:39:04.000000000 +0100
@@ -14,8 +14,6 @@
  * Added PPGETMODES/PPGETMODE/PPGETPHASE, Fred Barnes <frmb2@ukc.ac.uk>, 03/01/2001
  */
 
-#define PP_MAJOR	99
-
 #define PP_IOCTL	'p'
 
 /* Set mode for read/write (e.g. IEEE1284_MODE_EPP) */

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-02-26 23:08 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-26 23:09 [TRIVIAL] move PP_MAJOR from ppdev.h to major.h Rene Herman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.