Re: [PATCH 1/5] [CTNETLINK] Fix expectation mask dumping

[Pablo Neira Ayuso <pablo@netfilter.org>]

Hi Yasuyuki,

Yasuyuki KOZAKAI wrote:
> From: Pablo Neira Ayuso <pablo@netfilter.org>
> Date: Mon, 27 Feb 2006 03:10:18 +0100
> 
>>This patch introduces the function ctnetlink_exp_dump_mask, that
>>correctly dumps the expectation mask. Such function uses the l3num value
>>from the expectation tuple that is a valid layer 3 protocol number.
>>
>>The value of the l3num mask isn't dumped since it is meaningless from
>>the userspace side.
> 
> At first, this patch seems to be for net-2.6.17. This fix isn't really
> necessary to 2.6.16 ?

Yes, it's necessary.

> I've noticed missing nesting with CTA_EXP_MASK in this function. Please
> apply the attached patch on top of your patch. I tested it with ftp helper,
> ftp server, and telnet with IPv6. And I saw that kernel filled expectation
> mask in CTA_EXP_MASK area.

Thanks a lot Yasuyuki. Annoying that I forgot about this. I'm going to
resend a patch in some hours.

-- 
The dawn of the fourth age of Linux firewalling is coming; a time of
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris