From: Jeff Garzik <jgarzik@pobox.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>, linux-ide@vger.kernel.org
Subject: Re: [PATCH] Fixup ahci suspend / resume
Date: Tue, 28 Feb 2006 10:14:35 -0500 [thread overview]
Message-ID: <440468DB.5060605@pobox.com> (raw)
In-Reply-To: <44045FB1.5040408@suse.de>
Hannes Reinecke wrote:
> From: Hannes Reinecke <hare@suse.de>
> Subject: AHCI suspend / resume fixes.
>
> The current ahci driver has the problem that it doesn't resume properly.
> Or rather, that resuming is unstable.
> Reason being is that AHCI has 4 registers containing the DMA address it
> should write things to. Of course there is no guarantee that Linux has
> assigned the same address to the DMA area across reboots.
> So we should better re-initialize those registers after resume.
>
> The patch also improves the port_start / port_stop routines to be more
> closely modelled after the spec. This also avoids a nasty msleep(500)
> during initialisation.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
Seems sane at first glance, but can you please regenerate this against
libata-dev.git#upstream ?
Upstream 2.6.x doesn't care at all about suspend/resume, and AHCI has
seen several modifications in #upstream that are waiting for 2.6.17.
Jeff
next prev parent reply other threads:[~2006-02-28 15:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-28 14:35 [PATCH] Fixup ahci suspend / resume Hannes Reinecke
2006-02-28 14:45 ` Mark Lord
2006-02-28 14:59 ` Hannes Reinecke
2006-02-28 15:14 ` Jeff Garzik [this message]
2006-02-28 15:19 ` Jens Axboe
2006-02-28 15:22 ` Jeff Garzik
2006-02-28 15:28 ` Jens Axboe
2006-02-28 15:35 ` Jeff Garzik
2006-02-28 15:57 ` Hannes Reinecke
2006-02-28 17:25 ` Jens Axboe
2006-03-04 7:37 ` Randy.Dunlap
2006-03-06 8:36 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=440468DB.5060605@pobox.com \
--to=jgarzik@pobox.com \
--cc=hare@suse.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.