From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 01 Mar 2006 14:52:46 +0000 (GMT) Received: from smtp109.mail.mud.yahoo.com ([209.191.85.219]:53344 "HELO smtp109.mail.mud.yahoo.com") by ftp.linux-mips.org with SMTP id S8133138AbWCAOwf (ORCPT ); Wed, 1 Mar 2006 14:52:35 +0000 Received: (qmail 70826 invoked from network); 1 Mar 2006 15:00:19 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com.au; h=Received:Message-ID:Date:From:User-Agent:X-Accept-Language:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=uk+6687T9kQY+egMbUwOkw9k9w97Jg5Zop6QAOpQ5AgN3eKbh2LK9xiHi+Z7xZpxkg+wuVu+2Ojsec6a9mxtidSXX52wqJ/MdzMvtmdG2NUtcJNf2FrpkPM7CpOQT61rXFR7ZNYaCQPMt+t3CCVRGQoohTY4mTmpMuBIsYs2BLQ= ; Received: from unknown (HELO ?192.168.0.1?) (nickpiggin@203.173.4.201 with plain) by smtp109.mail.mud.yahoo.com with SMTP; 1 Mar 2006 15:00:19 -0000 Message-ID: <4405B700.1080607@yahoo.com.au> Date: Thu, 02 Mar 2006 02:00:16 +1100 From: Nick Piggin User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20051007 Debian/1.7.12-1 X-Accept-Language: en MIME-Version: 1.0 To: Atsushi Nemoto CC: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org Subject: Re: jiffies_64 vs. jiffies References: <20060301.144442.118975101.nemoto@toshiba-tops.co.jp> <20060301.210541.30439818.nemoto@toshiba-tops.co.jp> <44059915.3010800@yahoo.com.au> <20060301.235750.25910018.anemo@mba.ocn.ne.jp> In-Reply-To: <20060301.235750.25910018.anemo@mba.ocn.ne.jp> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 10703 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: nickpiggin@yahoo.com.au Precedence: bulk X-list: linux-mips Atsushi Nemoto wrote: >>>>>>On Wed, 01 Mar 2006 23:52:37 +1100, Nick Piggin said: > > >>>void do_timer(struct pt_regs *regs) >>>{ >>>- jiffies_64++; >>>- update_times(); >>>+ update_times(++jiffies_64); >>> softlockup_tick(regs); >>>} > > > nick> jiffies_64 is not volatile so you should not have to obfuscate > nick> the code like this. > > Well, do you mean it should be like this ? > > jiffies_64++; > update_times(jiffies_64); > Yeah. It makes your patch a line smaller too! > Thanks for your comments. Oh it was nothing really ;) -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com