From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C86EFC4345F for ; Fri, 19 Apr 2024 13:02:14 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.709088.1108331 (Exim 4.92) (envelope-from ) id 1rxnsE-0005ZH-Ul; Fri, 19 Apr 2024 13:01:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 709088.1108331; Fri, 19 Apr 2024 13:01:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rxnsE-0005ZA-SD; Fri, 19 Apr 2024 13:01:50 +0000 Received: by outflank-mailman (input) for mailman id 709088; Fri, 19 Apr 2024 13:01:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rxnsD-0005Z3-CI for xen-devel@lists.xenproject.org; Fri, 19 Apr 2024 13:01:49 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fae98dda-fe4c-11ee-b909-491648fe20b8; Fri, 19 Apr 2024 15:01:47 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 3E58E4EE0742; Fri, 19 Apr 2024 15:01:47 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fae98dda-fe4c-11ee-b909-491648fe20b8 MIME-Version: 1.0 Date: Fri, 19 Apr 2024 15:01:47 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, bertrand.marquis@arm.com, julien@xen.org, Simone Ballarin , Doug Goldstein , Julien Grall , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH v2] automation/eclair_analysis: substitute deprecated service STD.emptrecd In-Reply-To: <3c6e3fa1-a312-4872-9b7f-9e6935490bcb@suse.com> References: <7b60faa6e627b3a4df298f2ef4d9ba4d72e5e206.1713510915.git.nicola.vetrini@bugseng.com> <58ed38830469a027b9cedd9d5f68cfae@bugseng.com> <3c6e3fa1-a312-4872-9b7f-9e6935490bcb@suse.com> Message-ID: <4406fa44cb54d07bc43ffee6e42689da@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 2024-04-19 11:21, Jan Beulich wrote: > On 19.04.2024 09:49, Nicola Vetrini wrote: >> On 2024-04-19 09:35, Jan Beulich wrote: >>> On 19.04.2024 09:16, Nicola Vetrini wrote: >>>> The ECLAIR service STD.emptrecd is being deprecated; hence, as a >>>> preventive >>>> measure, STD.anonstct is used here, which for Xen's purposes has >>>> equivalent >>>> functionality. >>> >>> I'm sorry, but no, this still does not clarify things enough. It is >>> still >>> entirely unclear how "empty record" can reasonably be substituted by >>> "anonymous struct". Even the expansion of the respective >>> abbreviations >>> continues to be just a guess. >> >> anonstct checks for structs with no named members, > > So "anonstct" != "anonymous structures". As indicated, part of the > description wants to be de-ciphering of these acronyms, so they can > make sense to readers. > > Jan > >> hence also empty >> structs, but only the former is an undefined behaviour for C99. >> Would this be a sufficiently clear explanation for you? "The ECLAIR service STD.emptrecd (which checks for empty structures) is being deprecated; hence, as a preventive measure, STD.anonstct (which checks for structures with no named members, an UB in C99) is used here; the latter being a more general case than the previous one, this change does not affect the analysis. This new service is already supported by the current version of ECLAIR." -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)