From: David Vrabel <dvrabel@arcom.com>
To: jayakumar.alsa@gmail.com
Cc: Linux Kernel <linux-kernel@vger.kernel.org>, alsa-devel@alsa-project.org
Subject: [PATCH] ALSA: CS5535: shorter delays when accessing AC'97 codec registers
Date: Fri, 03 Mar 2006 16:09:51 +0000 [thread overview]
Message-ID: <44086A4F.1040403@arcom.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 446 bytes --]
The 10 ms sleeps while waiting for AC'97 codec register reads/writes to
complete are excessive given the maxmium time is one AC'97 frame (~21 us).
With AC'97 codecs with integrated touchscreens (like the UCB1400) this
improves the interactive performance of the touchscreen.
David Vrabel
--
David Vrabel, Design Engineer
Arcom, Clifton Road Tel: +44 (0)1223 411200 ext. 3233
Cambridge CB1 7EA, UK Web: http://www.arcom.com/
[-- Attachment #2: alsa-cs5535-quicker-ac97-register-accesses --]
[-- Type: text/plain, Size: 1365 bytes --]
ALSA: CS5535: shorter delays when accessing AC'97 codec registers
The 10 ms sleeps while waiting for AC'97 codec register reads/writes to
complete are excessive given the maxmium time is one AC'97 frame (~21 us).
With AC'97 codecs with integrated touchscreens (like the UCB1400) this
improves the interactive performance of the touchscreen.
Signed-off-by: David Vrabel <dvrabel@arcom.com>
Index: linux-2.6-working/sound/pci/cs5535audio/cs5535audio.c
===================================================================
--- linux-2.6-working.orig/sound/pci/cs5535audio/cs5535audio.c 2006-03-02 16:12:52.000000000 +0000
+++ linux-2.6-working/sound/pci/cs5535audio/cs5535audio.c 2006-03-03 15:47:30.000000000 +0000
@@ -62,7 +62,7 @@
tmp = cs_readl(cs5535au, ACC_CODEC_CNTL);
if (!(tmp & CMD_NEW))
break;
- msleep(10);
+ udelay(1);
} while (--timeout);
if (!timeout)
snd_printk(KERN_ERR "Failure writing to cs5535 codec\n");
@@ -80,14 +80,14 @@
regdata |= CMD_NEW;
cs_writel(cs5535au, ACC_CODEC_CNTL, regdata);
- wait_till_cmd_acked(cs5535au, 500);
+ wait_till_cmd_acked(cs5535au, 50);
timeout = 50;
do {
val = cs_readl(cs5535au, ACC_CODEC_STATUS);
if ((val & STS_NEW) && reg == (val >> 24))
break;
- msleep(10);
+ udelay(1);
} while (--timeout);
if (!timeout)
snd_printk(KERN_ERR "Failure reading cs5535 codec\n");
next reply other threads:[~2006-03-03 16:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-03 16:09 David Vrabel [this message]
2006-03-03 18:02 ` [PATCH] ALSA: CS5535: shorter delays when accessing AC'97 codec registers Takashi Iwai
2006-03-03 18:02 ` [Alsa-devel] " Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2006-03-03 16:09 David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44086A4F.1040403@arcom.com \
--to=dvrabel@arcom.com \
--cc=alsa-devel@alsa-project.org \
--cc=jayakumar.alsa@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.