-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Jan Kara wrote: >> The data journaling mode can be set as a flag associated with the inode. >> Currently, i_data_log is set in REISERFS_I(inode)->i_flags. I add >> i_data_ordered in one of my later patches. They can be tested easily >> with reiserfs_file_data_{log,ordered}. There's no reason that one >> couldn't be moved up and made a prerequisite for the first patch. > Fine. So we can just set proper journaling flags in reiserfs_quota_on > and then honor them in the internal writing functions. Ok, how do the attached patches look to you? The internal I/O changes need to be applied after the journaled xattr patch or we get an Oops trying to start a transaction without calling reiserfs_write_lock() first. I've modified the first patch in the xattr series to abstract out the fp->f_op->{read,write} calls to an xattr_{read,write} pair of functions. This makes it easier to move to the internal i/o code later. I've included it for clarity, but that is the only change. - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFECMCALPWxlyuTD7IRAlqfAJ0bQnHuNqzEif4hVfvGKI8tR2bUrACfU1Mg BFbe0xayAJHhvNgtGl7N6Jk= =P6ED -----END PGP SIGNATURE-----