From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2 2/2] mem: unmap unneeded space
Date: Wed, 02 May 2018 23:00:59 +0200 [thread overview]
Message-ID: <4409303.1sNuYAC1ue@xps> (raw)
In-Reply-To: <20180430125035.GB100464@bricha3-MOBL.ger.corp.intel.com>
30/04/2018 14:50, Bruce Richardson:
> On Mon, Apr 30, 2018 at 12:21:43PM +0100, Anatoly Burakov wrote:
> > When we ask to reserve virtual areas, we usually include
> > alignment in the mapping size, and that memory ends up
> > being wasted. Wasting a gigabyte of VA space while trying to
> > reserve one gigabyte is pretty expensive on 32-bit, so after
> > we're done mapping, unmap unneeded space.
> >
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> > ---
> >
> > Notes:
> > v2:
> > - Split fix for size_t overflow into separate patch
> > - Improve readability of unmapping code
> > - Added comment explaining why unmapping is done
> >
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
I am not confident pushing this change post-rc1.
Please can we have more validation tests with this patch?
next prev parent reply other threads:[~2018-05-02 21:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 16:35 [PATCH] mem: unmap unneeded space Anatoly Burakov
2018-04-27 16:32 ` Bruce Richardson
2018-04-27 16:38 ` Bruce Richardson
2018-04-30 11:21 ` [PATCH v2 1/2] mem: check if allocation size is too big Anatoly Burakov
2018-04-30 12:49 ` Bruce Richardson
2018-04-30 11:21 ` [PATCH v2 2/2] mem: unmap unneeded space Anatoly Burakov
2018-04-30 12:50 ` Bruce Richardson
2018-05-02 21:00 ` Thomas Monjalon [this message]
2018-05-08 20:20 ` Thomas Monjalon
2018-05-13 23:33 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4409303.1sNuYAC1ue@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.