From: gimli <gimli@dark-green.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: mactel-linux-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [Mactel-linux-devel] Re: [PATCH] /sys/firmware/efi/systab giving incorrect value for smbios
Date: Sat, 04 Mar 2006 20:04:08 +0100 [thread overview]
Message-ID: <4409E4A8.70902@dark-green.com> (raw)
In-Reply-To: <20060304190026.GA4041@srcf.ucam.org>
Hi.
Do you have any idea why the kernel crashes on machines with more then 512 MB ram ?
cu
gimli
Matthew Garrett wrote:
> Or, as an alternative, remove the virtual to physical mapping that
> efivars does. This requires fixing up IA64 to match. I've no idea which
> approach is right.
>
> Signed-off-by: Matthew Garrett <mjg59@srcf.ucam.org>
>
> diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
> index bda5bce..ba598af 100644
> --- a/drivers/firmware/efivars.c
> +++ b/drivers/firmware/efivars.c
> @@ -575,7 +575,7 @@ systab_read(struct subsystem *entry, cha
> if (efi.acpi)
> str += sprintf(str, "ACPI=0x%lx\n", __pa(efi.acpi));
> if (efi.smbios)
> - str += sprintf(str, "SMBIOS=0x%lx\n", __pa(efi.smbios));
> + str += sprintf(str, "SMBIOS=0x%lx\n", efi.smbios);
> if (efi.hcdp)
> str += sprintf(str, "HCDP=0x%lx\n", __pa(efi.hcdp));
> if (efi.boot_info)
> diff --git a/arch/ia64/kernel/efi.c b/arch/ia64/kernel/efi.c
> index a3aa45c..ff3795b 100644
> --- a/arch/ia64/kernel/efi.c
> +++ b/arch/ia64/kernel/efi.c
> @@ -451,7 +451,7 @@ efi_init (void)
> efi.acpi = __va(config_tables[i].table);
> printk(" ACPI=0x%lx", config_tables[i].table);
> } else if (efi_guidcmp(config_tables[i].guid, SMBIOS_TABLE_GUID) == 0) {
> - efi.smbios = __va(config_tables[i].table);
> + efi.smbios = config_tables[i].table;
> printk(" SMBIOS=0x%lx", config_tables[i].table);
> } else if (efi_guidcmp(config_tables[i].guid, SAL_SYSTEM_TABLE_GUID) == 0) {
> efi.sal_systab = __va(config_tables[i].table);
>
next prev parent reply other threads:[~2006-03-04 19:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-04 18:00 [PATCH] /sys/firmware/efi/systab giving incorrect value for smbios Matthew Garrett
2006-03-04 18:04 ` [PATCH] Remove __init from efi_get_time Matthew Garrett
2006-03-04 19:00 ` [PATCH] /sys/firmware/efi/systab giving incorrect value for smbios Matthew Garrett
2006-03-04 19:04 ` gimli [this message]
2006-03-04 19:17 ` [Mactel-linux-devel] " Matthew Garrett
-- strict thread matches above, loose matches on Subject: below --
2006-03-09 22:13 Tolentino, Matthew E
2006-03-09 23:00 ` gimli
2006-03-10 16:34 Tolentino, Matthew E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4409E4A8.70902@dark-green.com \
--to=gimli@dark-green.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mactel-linux-devel@lists.sourceforge.net \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.