From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: Carlos.Pardo@siliconimage.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH 5/6] sata_sil: convert sil_port[] to u16 from unsigned long
Date: Sun, 05 Mar 2006 10:50:20 -0500 [thread overview]
Message-ID: <440B08BC.5090409@pobox.com> (raw)
In-Reply-To: <440A97CD.30404@gmail.com>
Tejun Heo wrote:
> Jeff Garzik wrote:
>
>> Tejun Heo wrote:
>>
>>> unsigned long is way too big for sil_port[] offsets (currently the
>>> table is 256 bytes on 64bit machines). Convert sil_port[] to u16.
>>>
>>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>>
>>
>>
>> NAK. This just forces the compiler to promote these from u16 to
>> machine int (i.e. unsigned long) at addition time. Table size is a
>> very trivial matter.
>>
>
> Wouldn't that be cheaper than extra cache lines? I'm pretty sure it
> would be on x86/64.
Actually, when I got this reply, I looked at it again. sil_port[] is
only used at startup, therefore performance is not an issue, and we
don't care (within reason) how big the table is. So, I would rather
leave it in native format (machine int -> unsigned long).
Jeff
next prev parent reply other threads:[~2006-03-05 15:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-05 7:03 [PATCHSET] sata_sil misc updates Tejun Heo
2006-03-05 7:03 ` [PATCH 6/6] sata_sil: cosmetic flag/constant changes Tejun Heo
2006-03-05 7:03 ` [PATCH 4/6] sata_sil: replace register address constants with sil_port[] entry Tejun Heo
2006-03-05 7:03 ` [PATCH 2/6] sata_sil: kill bogus PCI ID 0x1095/0x0240 Tejun Heo
2006-03-05 7:41 ` Jeff Garzik
2006-03-05 7:51 ` Tejun Heo
2006-03-05 7:03 ` [PATCH 3/6] sata_sil: use kzalloc Tejun Heo
2006-03-05 7:03 ` [PATCH 5/6] sata_sil: convert sil_port[] to u16 from unsigned long Tejun Heo
2006-03-05 7:43 ` Jeff Garzik
2006-03-05 7:48 ` Tejun Heo
2006-03-05 15:50 ` Jeff Garzik [this message]
2006-03-05 7:03 ` [PATCH 1/6] sata_sil: replace sil_3112_m15w board id with sil_3112 Tejun Heo
2006-03-05 7:40 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=440B08BC.5090409@pobox.com \
--to=jgarzik@pobox.com \
--cc=Carlos.Pardo@siliconimage.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.