All of lore.kernel.org
 help / color / mirror / Atom feed
From: r.marek@sh.cvut.cz (Rudolf Marek)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] [PATCH] Add fan control support to W83627EHF
Date: Sun, 05 Mar 2006 20:05:33 +0000	[thread overview]
Message-ID: <440B448D.4090609@sh.cvut.cz> (raw)
In-Reply-To: <4409FFA1.7050109@sh.cvut.cz>

Hello again,

> The tempX_target register can still contain a target temperature,
> either the default value loaded by the BIOS or the last temp target
> when the chip was in temp cruise. fanX_target is a good way to add the
> sysfs interface, I like that.

Yep. The target temp register is shared with this speed register so some logic in the driver
must be programmed.

> 
> RPM cruise allows me to set an RPM directly without knowing the PWM
> value. Or, more specifically, it's good for low RPMs, which are hard
> to get perfectly right, since the PWM value is typically 100 or so. At
> PWM values of 70 or so, the fan just stops spinning. Yes, if I wanted
> to read out the RPM value and tinker with the PWM until I got the RPM
> I wanted, I could find what the low threshold is where the fan
> overcomes friction and starts spinning. But that's why RPM cruise is
> so nice.

Ok now I get it.

> Anyway, as long as the chip implements it, it doesn't hurt to export
> the interface, right?

I will certainly have no time for this in next 5 days. So feel free to implement it.
(As the patch on the top of mine) If you have time please check my implementation or
change it so it is even better :) (also provide a patch on top of my original patch)

So to restore the RPM cruise you need to delete both mapping arrays (USER_MAP and CHIP_MAP iirc)
then the pwm_enable will be like:
            * 0 Manual mode
            * 1 Thermal Cruise
            * 2 Fan Speed Cruise
            * 3 Smart FAN III
This has to be fixed so 0 is disabled (to comply with the interface def)
So best to emulate disabled (please check datasheet if it cannot be disabled) is to write 255 to corresponding
pwm ...

Thanks,

Regards
Rudolf



  parent reply	other threads:[~2006-03-05 20:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-04 20:59 [lm-sensors] [PATCH] Add fan control support to W83627EHF Rudolf Marek
2006-03-04 21:17 ` David Hubbard
2006-03-04 21:47 ` Rudolf Marek
2006-03-05  9:52 ` Rudolf Marek
2006-03-05 16:42 ` David Hubbard
2006-03-05 20:05 ` Rudolf Marek [this message]
2006-03-05 21:10 ` David Hubbard
2006-03-05 21:14 ` Rudolf Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=440B448D.4090609@sh.cvut.cz \
    --to=r.marek@sh.cvut.cz \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.