From: Ivan Gyurdiev <ivg2@cornell.edu>
To: "Serge E. Hallyn" <serue@us.ibm.com>
Cc: SELinux <selinux@tycho.nsa.gov>
Subject: Re: libsemanage/src/semanage_store.c:semanage_split_fc
Date: Mon, 06 Mar 2006 21:03:43 -0500 [thread overview]
Message-ID: <440CE9FF.2090201@cornell.edu> (raw)
In-Reply-To: <20060306221519.GA25033@sergelap.austin.ibm.com>
Serge E. Hallyn wrote:
> In semanage_split_fc(), linex 887 and 893, the file_con fd is not closed
> on error. Trivial patch follows.
>
>
There's already a cleanup: goto target, I think that should be used instead
(after initializing the file descriptors, and making the close
statements conditional).
It'd be nice if close(-1) and fclose(NULL) were no-ops.
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2006-03-07 2:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-06 22:15 libsemanage/src/semanage_store.c:semanage_split_fc Serge E. Hallyn
2006-03-07 2:03 ` Ivan Gyurdiev [this message]
2006-03-08 15:05 ` libsemanage/src/semanage_store.c:semanage_split_fc Stephen Smalley
2006-03-08 16:23 ` libsemanage/src/semanage_store.c:semanage_split_fc Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=440CE9FF.2090201@cornell.edu \
--to=ivg2@cornell.edu \
--cc=selinux@tycho.nsa.gov \
--cc=serue@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.