From: Badari Pulavarty <pbadari@us.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.6.16-rc5-mm2 mpage_readpages() cleanup
Date: Tue, 07 Mar 2006 00:14:46 -0800 [thread overview]
Message-ID: <440D40F6.4030803@us.ibm.com> (raw)
In-Reply-To: 20060306143718.50fc0d94.akpm@osdl.org
Andrew Morton wrote:
>Badari Pulavarty <pbadari@us.ibm.com> wrote:
>
>>Instead of passing validity of block mapping, do_mpage_readpage()
>> can figure it out using buffer_mapped(). This will reduce one
>> un-needed argument passing.
>>
>
>Is buffer_mapped() the correct flag to use? Remember that get_block() can
>validly return a !buffer_mapped() bh over a file hole.
>
Yes. Currently the code which handles hole can only deal with a single
block at a time.
All I am trying to do is, find out when to do next getblock() call.
>
>Either way, there should be a comment in there explaining the protocol,
>please.
>
Will do.
Thanks,
Badari
next prev parent reply other threads:[~2006-03-07 0:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-06 22:31 [PATCH] 2.6.16-rc5-mm2 mpage_readpages() cleanup Badari Pulavarty
2006-03-06 22:37 ` Andrew Morton
2006-03-07 8:14 ` Badari Pulavarty [this message]
2006-03-07 16:26 ` Badari Pulavarty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=440D40F6.4030803@us.ibm.com \
--to=pbadari@us.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.