All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phillip Susi <psusi@cfl.rr.com>
To: Pekka J Enberg <penberg@cs.Helsinki.FI>
Cc: linux kernel <linux-kernel@vger.kernel.org>, akpm@osdl.org
Subject: Re: [PATCH] udf: fix uid/gid options and add uid/gid=ignore and forget options
Date: Tue, 07 Mar 2006 10:49:14 -0500	[thread overview]
Message-ID: <440DAB7A.2040301@cfl.rr.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0603070920360.15092@sbz-30.cs.Helsinki.FI>

Pekka J Enberg wrote:
> Looks like you're using two spaces. Indentation is one tab and one tab is 
> exactly eight characters (see Documentation/CodingStyle).
> 

Wow!  8 spaces?  I always go with 4, 8 wastes way too much screen space. 
  Is there a handy incantation to get emacs to auto indent with a hard 
tab rather than 2 spaces like it does by default?

> Okay, fair enough. I see akpm has taken your patch. Please make sure the 
> mount options are documented. Thanks!
> 

I wrote up some docs for it last night.

> (Please note that we didn't fix the unconditional memset now, so there's 
>  dead code in udf_update_inode(). The check for TAG_IDENT_USE will always 
>  fail.)

Hrm... I'll take a look at that tonight and see what I come up with. 
Probably will resubmit the patch tomorrow.




  reply	other threads:[~2006-03-07 15:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-04 19:32 [PATCH] udf: fix uid/gid options and add uid/gid=ignore and forget options Phillip Susi
2006-03-05 19:22 ` Pekka Enberg
2006-03-06  1:10   ` Phillip Susi
2006-03-06  7:31     ` Pekka J Enberg
2006-03-07  3:23       ` Phillip Susi
2006-03-07  7:24         ` Pekka J Enberg
2006-03-07 15:49           ` Phillip Susi [this message]
2006-03-07 16:50             ` Sergey Vlasov
  -- strict thread matches above, loose matches on Subject: below --
2006-03-20  2:32 Phillip Susi
2006-03-20  4:04 ` Andrew Morton
2006-03-20 16:25   ` Phillip Susi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=440DAB7A.2040301@cfl.rr.com \
    --to=psusi@cfl.rr.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@cs.Helsinki.FI \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.