diff for duplicates of <440DBD64.2080601@torque.net> diff --git a/a/1.txt b/N1/1.txt index 6012e53..b08b8a4 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -60,7 +60,7 @@ Jeff Garzik wrote: >> - rbuf[4 + 3] = strlen(inq_83_str); >> - memcpy(rbuf + 4 + 4, inq_83_str, strlen(inq_83_str)); >> + if (buflen > (ATA_SERNO_LEN + num + 3)) { ->> + /* piv=0, assoc=lu, code_set¨SII, designator=vendor */ +>> + /* piv=0, assoc=lu, code_set=ACSII, designator=vendor */ >> + rbuf[num + 0] = 2; >> + rbuf[num + 3] = ATA_SERNO_LEN; >> + num += 4; @@ -71,7 +71,7 @@ Jeff Garzik wrote: >> - >> + if (buflen > (sat_model_serial_desc_len + num + 3)) { >> + /* SAT defined lu model and serial numbers descriptor */ ->> + /* piv=0, assoc=lu, code_set¨SII, designator=t10 vendor id */ +>> + /* piv=0, assoc=lu, code_set=ACSII, designator=t10 vendor id */ >> + rbuf[num + 0] = 2; >> + rbuf[num + 1] = 1; >> + rbuf[num + 3] = sat_model_serial_desc_len; @@ -123,20 +123,7 @@ the linux libata implementation of SAT, I'm not sure where that should go. VPD page 0x83 for device identification doesn't seem appropriate. If a linux box was being used as a FC to SATA bridge then the bridge should be putting -FC related stuff in assoc=port and assocfivice while +FC related stuff in assoc=port and assoc=device while keeping what libata put in assoc=lu. Doug Gilbert - - - - -------------------------------------------------------- -This SF.Net email is sponsored by xPML, a groundbreaking scripting language -that extends applications into web and mobile media. Attend the live webcast -and join the prime developer group breaking into this new coding territory! -http://sel.as-us.falkag.net/sel?cmd=lnk&kid\x110944&bid$1720&dat\x121642 -_______________________________________________ -Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net -Linux-hotplug-devel@lists.sourceforge.net -https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel diff --git a/a/content_digest b/N1/content_digest index 1f8d76d..81c9c56 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -11,7 +11,7 @@ "ref\0440C96B0.7040404@pobox.com\0" "From\0Douglas Gilbert <dougg@torque.net>\0" "Subject\0Re: [PATCH] /dev/disk/by-id incomplete and unhelpful for SATA drives\0" - "Date\0Tue, 07 Mar 2006 17:05:40 +0000\0" + "Date\0Tue, 07 Mar 2006 12:05:40 -0500\0" "To\0Jeff Garzik <jgarzik@pobox.com>\0" "Cc\0patman@aracnet.com" Chris Paulson-Ellis <chris@edesix.com> @@ -83,7 +83,7 @@ ">> - rbuf[4 + 3] = strlen(inq_83_str);\n" ">> - memcpy(rbuf + 4 + 4, inq_83_str, strlen(inq_83_str));\n" ">> + if (buflen > (ATA_SERNO_LEN + num + 3)) {\n" - ">> + /* piv=0, assoc=lu, code_set\302\250SII, designator=vendor */\n" + ">> + /* piv=0, assoc=lu, code_set=ACSII, designator=vendor */\n" ">> + rbuf[num + 0] = 2; \n" ">> + rbuf[num + 3] = ATA_SERNO_LEN;\n" ">> + num += 4;\n" @@ -94,7 +94,7 @@ ">> -\n" ">> + if (buflen > (sat_model_serial_desc_len + num + 3)) {\n" ">> + /* SAT defined lu model and serial numbers descriptor */\n" - ">> + /* piv=0, assoc=lu, code_set\302\250SII, designator=t10 vendor id */\n" + ">> + /* piv=0, assoc=lu, code_set=ACSII, designator=t10 vendor id */\n" ">> + rbuf[num + 0] = 2; \n" ">> + rbuf[num + 1] = 1; \n" ">> + rbuf[num + 3] = sat_model_serial_desc_len;\n" @@ -146,22 +146,9 @@ "that should go. VPD page 0x83 for device identification\n" "doesn't seem appropriate. If a linux box was being used\n" "as a FC to SATA bridge then the bridge should be putting\n" - "FC related stuff in assoc=port and assoc\357\254\201vice while\n" + "FC related stuff in assoc=port and assoc=device while\n" "keeping what libata put in assoc=lu.\n" "\n" - "Doug Gilbert\n" - "\n" - "\n" - "\n" - "\n" - "-------------------------------------------------------\n" - "This SF.Net email is sponsored by xPML, a groundbreaking scripting language\n" - "that extends applications into web and mobile media. Attend the live webcast\n" - "and join the prime developer group breaking into this new coding territory!\n" - "http://sel.as-us.falkag.net/sel?cmd=lnk&kid\0210944&bid$1720&dat\0221642\n" - "_______________________________________________\n" - "Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net\n" - "Linux-hotplug-devel@lists.sourceforge.net\n" - https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel + Doug Gilbert -1d92ca4c861e19b16dbdfe99c4ee26e324cc61f2d5b06d19668f1bbf827b4468 +b1b6169d58108c4239271998521f1d4846b0acd1da59304adcfd75515d3fa054
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.