From: Bill Davidsen <davidsen@tmr.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
markhe@nextd.demon.co.uk, Andrea Arcangeli <andrea@suse.de>,
Mike Christie <michaelc@cs.wisc.edu>,
James Bottomley <James.Bottomley@steeleye.com>,
Jens Axboe <axboe@suse.de>, Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: Slab corruption in 2.6.16-rc5-mm2
Date: Tue, 07 Mar 2006 14:28:41 -0500 [thread overview]
Message-ID: <440DDEE9.8090604@tmr.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0603061423160.13139@g5.osdl.org>
Linus Torvalds wrote:
> has been incorrectly translated for several reasons:
>
> - we shouldn't check "cachep->num > offslab_limit". We should check just
> "num > offslab_limit" (cachep->num is the _previous_ number we tested).
>
> - when we do "break", we've already incremented "gfporder", and we should
> correct for that.
>
> Now, maybe I'm just off my rocker again (I've certainly been batting 0.000
> so far, even if I think I've been finding real bugs). So who knows. But I
> get the feeling that that patch is broken.
I thought stumbling over bugs while looking for other things was part of
the new development model ;-)
>
> Either revert it, or try this (TOTALLY UNTESTED!!!) patch..
>
> And hey, maybe I'm just crazy.
Being crazy and being right are not mutually exclusize.
--
-bill davidsen (davidsen@tmr.com)
"The secret to procrastination is to put things off until the
last possible moment - but no longer" -me
next prev parent reply other threads:[~2006-03-08 16:09 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-06 0:17 Slab corruption in 2.6.16-rc5-mm2 Jesper Juhl
2006-03-06 18:25 ` Linus Torvalds
2006-03-06 18:43 ` Jesper Juhl
2006-03-06 19:32 ` Linus Torvalds
2006-03-06 19:51 ` Jesper Juhl
2006-03-06 19:58 ` Jesper Juhl
2006-03-06 20:06 ` Linus Torvalds
2006-03-06 20:24 ` Jesper Juhl
2006-03-06 20:30 ` Jens Axboe
2006-03-06 20:33 ` Jens Axboe
2006-03-06 21:14 ` Jesper Juhl
2006-03-06 21:41 ` Jesper Juhl
2006-03-06 21:55 ` Dave Jones
2006-03-06 21:57 ` Jesper Juhl
2006-03-09 15:50 ` Martin J. Bligh
2006-03-09 15:54 ` Martin J. Bligh
2006-03-09 15:54 ` Benjamin LaHaise
2006-03-09 16:04 ` Martin J. Bligh
2006-03-09 16:08 ` Linus Torvalds
2006-03-09 16:41 ` Dave Jones
2006-03-06 20:36 ` Jesper Juhl
2006-03-06 20:53 ` Jesper Juhl
2006-03-06 20:56 ` Jesper Juhl
2006-03-06 21:07 ` Linus Torvalds
2006-03-06 21:16 ` Jesper Juhl
2006-03-06 21:54 ` Jesper Juhl
2006-03-06 22:05 ` Andrew Morton
2006-03-06 22:08 ` Jesper Juhl
2006-03-06 22:27 ` Jesper Juhl
2006-03-06 22:17 ` Linus Torvalds
2006-03-06 22:34 ` Linus Torvalds
2006-03-06 22:52 ` Jesper Juhl
2006-03-06 22:54 ` Linus Torvalds
2006-03-06 23:01 ` Jesper Juhl
2006-03-06 23:06 ` Andrew Morton
2006-03-06 23:24 ` Jesper Juhl
2006-03-07 0:17 ` Linus Torvalds
2006-03-07 0:25 ` Jesper Juhl
2006-03-07 3:15 ` Mike Christie
2006-03-07 3:20 ` Linus Torvalds
2006-03-07 18:01 ` James Bottomley
2006-03-07 19:40 ` Jesper Juhl
2006-03-07 8:47 ` [PATCH] slab: fix offslab_limit in calculate_slab_order (Was: Slab corruption in 2.6.16-rc5-mm2) Pekka J Enberg
2006-03-07 17:12 ` Linus Torvalds
2006-03-07 19:21 ` Pekka Enberg
2006-03-07 19:28 ` Bill Davidsen [this message]
2006-03-06 22:44 ` Slab corruption in 2.6.16-rc5-mm2 Jesper Juhl
2006-03-06 18:48 ` Mike Christie
2006-03-06 18:49 ` Mike Christie
-- strict thread matches above, loose matches on Subject: below --
2006-03-08 6:25 Chuck Ebbert
2006-03-08 8:32 ` Nick Piggin
2006-03-08 8:46 ` Andrew Morton
2006-03-08 9:02 ` Nick Piggin
2006-03-08 9:12 ` Andrew Morton
2006-03-08 9:23 ` Nick Piggin
2006-03-08 14:35 ` Lee Schermerhorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=440DDEE9.8090604@tmr.com \
--to=davidsen@tmr.com \
--cc=James.Bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=andrea@suse.de \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=markhe@nextd.demon.co.uk \
--cc=michaelc@cs.wisc.edu \
--cc=penberg@cs.helsinki.fi \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.