From: "Daniel K." <daniel@cluded.net>
To: Eric Sesterhenn <snakebyte@gmx.de>
Cc: linux-kernel@vger.kernel.org, raupach@nwfs1.rz.fh-hannover.de
Subject: Re: [Patch] Fix dead code in cdrom/gscd.c
Date: Wed, 08 Mar 2006 11:37:49 +0000 [thread overview]
Message-ID: <440EC20D.3090004@cluded.net> (raw)
In-Reply-To: <1141808871.6355.5.camel@alice>
Eric Sesterhenn wrote:
> hi,
>
> this fixes Coverity Bugs #21 and #22. In both cases the
> do { ... } while (result != 6 || result == 0x0E) just
This is completely wrong, and should be fixed too.
Either
do { ... } while (result != 6)
is correct, or this is the result of a thinko, and it should be
do { ... } while (result != 6 && result != 0x0E)
in which case your patch is incorrect.
> finishes for result == 6, so the if(result != 6) doesnt
> make much sense.
Unless its presence is an indication of faulty logic in the while clause
Daniel K.
prev parent reply other threads:[~2006-03-08 11:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-08 9:07 [Patch] Fix dead code in cdrom/gscd.c Eric Sesterhenn
2006-03-08 11:37 ` Daniel K. [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=440EC20D.3090004@cluded.net \
--to=daniel@cluded.net \
--cc=linux-kernel@vger.kernel.org \
--cc=raupach@nwfs1.rz.fh-hannover.de \
--cc=snakebyte@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.