From: Hannes Reinecke <hare@suse.de>
To: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: [PATCH 07/07] aic79xx: Avoid renegotiation on inquiry
Date: Wed, 08 Mar 2006 13:00:07 +0100 [thread overview]
Message-ID: <440EC747.9060502@suse.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 397 bytes --]
Because of some quirk in the SCSI spec the aic79xx driver chose to
force a renegotiation when sending an inquiry. This should better
be handled by the upper layers if required at all.
Signed-off-by: Hannes Reinecke <hare@suse.de>
--
Dr. Hannes Reinecke hare@suse.de
SuSE Linux Products GmbH S390 & zSeries
Maxfeldstraße 5 +49 911 74053 688
90409 Nürnberg http://www.suse.de
[-- Attachment #2: 07-aic79xx-avoid-renegotiation-on-inquiry.txt --]
[-- Type: text/plain, Size: 1842 bytes --]
[PATCH 07/07] aic79xx: Avoid renegotiation on inquiry
Because of some quirk in the SCSI spec the aic79xx driver chose to
force a renegotiation when sending an inquiry. This should better
be handled by the upper layers if required at all.
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
drivers/scsi/aic7xxx/aic79xx_osm.c | 24 ------------------------
1 files changed, 0 insertions(+), 24 deletions(-)
856120bb85cf6555ef268d62fcbc0fb404d7b06e
diff --git a/drivers/scsi/aic7xxx/aic79xx_osm.c b/drivers/scsi/aic7xxx/aic79xx_osm.c
index 7b9dbef..c97ef05 100644
--- a/drivers/scsi/aic7xxx/aic79xx_osm.c
+++ b/drivers/scsi/aic7xxx/aic79xx_osm.c
@@ -1526,30 +1526,6 @@ ahd_linux_run_command(struct ahd_softc *
if ((tstate->auto_negotiate & mask) != 0) {
scb->flags |= SCB_AUTO_NEGOTIATE;
scb->hscb->control |= MK_MESSAGE;
- } else if (cmd->cmnd[0] == INQUIRY
- && (tinfo->curr.offset != 0
- || tinfo->curr.width != MSG_EXT_WDTR_BUS_8_BIT
- || tinfo->curr.ppr_options != 0)
- && (tinfo->curr.ppr_options & MSG_EXT_PPR_IU_REQ)==0) {
- /*
- * The SCSI spec requires inquiry
- * commands to complete without
- * reporting unit attention conditions.
- * Because of this, an inquiry command
- * that occurs just after a device is
- * reset will result in a data phase
- * with mismatched negotiated rates.
- * The core already forces a renegotiation
- * for reset events that are visible to
- * our controller or that we initiate,
- * but a third party device reset or a
- * hot-plug insertion can still cause this
- * issue. Therefore, we force a re-negotiation
- * for every inquiry command unless we
- * are async.
- */
- scb->flags |= SCB_NEGOTIATE;
- scb->hscb->control |= MK_MESSAGE;
}
if ((dev->flags & (AHD_DEV_Q_TAGGED|AHD_DEV_Q_BASIC)) != 0) {
--
1.1.3
reply other threads:[~2006-03-08 12:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=440EC747.9060502@suse.de \
--to=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.