From: Patrick McHardy <kaber@trash.net>
To: Amin Azez <azez@ufomechanic.net>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [patch] ipt_recent
Date: Wed, 08 Mar 2006 13:16:27 +0100 [thread overview]
Message-ID: <440ECB1B.4070507@trash.net> (raw)
In-Reply-To: <440DAB6B.4020208@ufomechanic.net>
Amin Azez wrote:
> Patrick McHardy wrote:
>
>>> @@ -20,6 +25,8 @@
>>> u_int32_t hit_count;
>>> u_int8_t check_set;
>>> u_int8_t invert;
>>> + u_int8_t check_count;
>>> + u_int32_t entry_count;
>>> char name[IPT_RECENT_NAME_LEN];
>>> u_int8_t side;
>>> };
>>
>>
>>
>> Sorry, we can't do that since it breaks userspace compatibility. But I'm
>> really glad someone finally has the stomach to touch ipt_recent, I'll
>> review your other patches now.
>
>
> I've reworked that functionality significantly in a new patch to send
> next week. I will see if I can find a way to make use of existing
> structures to add the functionality.
Otherwise you can you versioning as in ipt_MARK and a couple of other
targets.
>
> I heard tell that ipt_recent needed a maintainer?
Yes, we need someone familiar with the code to review patches, fix
bugs and clean it up.
next prev parent reply other threads:[~2006-03-08 12:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-17 17:37 ipt_recent fix Amin Azez
2006-02-20 16:12 ` [patch] ipt_recent Amin Azez
2006-03-04 10:00 ` Patrick McHardy
2006-03-07 15:48 ` Amin Azez
2006-03-08 12:16 ` Patrick McHardy [this message]
2006-03-13 17:47 ` ipt_recent patch Amin Azez
2006-03-22 14:26 ` Stephen Frost
2006-05-03 9:32 ` Amin Azez
2006-05-03 11:41 ` Amin Azez
2006-03-22 12:04 ` [patch] ipt_recent Amin Azez
2006-02-21 11:16 ` BUG: More ipt_recent queries Amin Azez
2006-02-21 16:28 ` Amin Azez
2006-03-04 10:13 ` Patrick McHardy
2006-03-06 3:04 ` Stephen Frost
2006-03-07 15:46 ` Amin Azez
2006-03-04 10:10 ` ipt_recent fix Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=440ECB1B.4070507@trash.net \
--to=kaber@trash.net \
--cc=azez@ufomechanic.net \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.