All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Madhavan Srinivasan <maddy@linux.ibm.com>,
	<michal.kubiak@intel.com>, <ramu.r@intel.com>,
	<anthony.l.nguyen@intel.com>, LKML <linux-kernel@vger.kernel.org>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: [linux-next20250912] Build warnings at drivers/net/ethernet/intel/idpf/xdp.c:6
Date: Fri, 12 Sep 2025 15:30:08 +0200	[thread overview]
Message-ID: <440ef1ad-6690-48e9-be02-1ccd69f6623e@intel.com> (raw)
In-Reply-To: <22ac36cb-1ba5-429b-85e0-4e3f2da1f87f@linux.ibm.com>

From: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
Date: Fri, 12 Sep 2025 18:39:33 +0530

> Greetings!!!
> 
> 
> IBM CI has reported a build warning on IBM Power Server, on linux-
> next20250912 kernel.
> 
> 
> gcc version 11.5.0 20240719 (Red Hat 11.5.0-2) (GCC)
> 
> GNU ld version 2.35.2-54.el9
> 
> 
> Attached is the .config file.
> 
> 
> Warnings:
> 
> In file included from drivers/net/ethernet/intel/idpf/xdp.c:6:
> drivers/net/ethernet/intel/idpf/xdp.h: In function ‘idpf_xdp_tx_xmit’:
> drivers/net/ethernet/intel/idpf/xdp.h:28:20: note: the ABI of passing
> aggregates with 16-byte alignment has changed in GCC 5
>    28 | static inline void idpf_xdp_tx_xmit(struct libeth_xdp_tx_desc
> desc, u32 i,
>       |                    ^~~~~~~~~~~~~~~~

Yes, I do pass 16-byte variables/structures directly.

I would say this warning makes no sense, due to the following reasons:

1. IIRC the minimum required GCC version for building the latest kernel
   is way above 5.
2. This warning should appear only with `-Wabi`, which the upstream
   kernel never sets.
3. Kernel is a self-contained project, this function is not uAPI, so we
   shouldn't care in general about backward ABI compatibility for purely
   in-kernel stuff.

We have plenty of functions, mostly generic, which either passes or
returns >= 16-byte objects, but I see this warning for the first time.
Despite that my repo is attached to the open Intel CI bots infra which
does daily builds on a good bunch of different architectures and
toolchains (inc. GCC 8+).

> 
> 
> Git bisect is pointing below commit as the first bad commit.
> 
> 
> first bad commit: [cba102cd719029a10bda1d0ca00ed646796f1f21] idpf: add
> support for XDP on Rx

Thanks,
Olek

  reply	other threads:[~2025-09-12 13:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-12 13:09 [linux-next20250912] Build warnings at drivers/net/ethernet/intel/idpf/xdp.c:6 Venkat Rao Bagalkote
2025-09-12 13:30 ` Alexander Lobakin [this message]
2025-10-13  3:57   ` Venkat
2025-10-13 15:32     ` Alexander Lobakin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=440ef1ad-6690-48e9-be02-1ccd69f6623e@intel.com \
    --to=aleksander.lobakin@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=michal.kubiak@intel.com \
    --cc=ramu.r@intel.com \
    --cc=sfr@canb.auug.org.au \
    --cc=venkat88@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.