All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kirill Korotaev <dev@sw.ru>
To: Jan Blunck <jblunck@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
	balbir@in.ibm.com, viro@zeniv.linux.org.uk, olh@suse.de,
	neilb@suse.de, dev@openvz.org, bsingharora@gmail.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix shrink_dcache_parent() against shrink_dcache_memory() race (updated patch)
Date: Thu, 09 Mar 2006 17:36:00 +0300	[thread overview]
Message-ID: <44103D50.7010108@sw.ru> (raw)
In-Reply-To: <20060309140827.GH4243@hasse.suse.de>

>>>Are we all happy with this patch now?
>>
>>I can't see why we fix shrink_dcache_parent() only, why 
>>shrink_dcache_anon() is totally missed?
>>
> 
> 
> First of all because anon-dentries don't have a parent. So they are not a real
> problem in don't restarting the shrink_dcache_anon() if we waited for prunes.
> Since I've reordered the calls to shrink_dcache_anon() and
> shrink_dcache_parent() in generic_shutdown_super() they are handled as normal
> dentries if they are pruned through shrink_dcache_memory() from the d_lru list.
This looks a bad idea to reorder calls to achieve such a behvaiour.
I would move the loop outside of shrink_dcache_parent to 
generic_shutdown_super instead.

Thanks,
Kirill



  reply	other threads:[~2006-03-09 14:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-08 14:51 [PATCH] Fix shrink_dcache_parent() against shrink_dcache_memory() race (updated patch) Jan Blunck
2006-03-09  6:33 ` Balbir Singh
2006-03-09 11:00   ` Jan Blunck
2006-03-09 11:21     ` Andrew Morton
2006-03-09 11:58       ` Jan Blunck
2006-03-09 12:53       ` Kirill Korotaev
2006-03-09 14:08         ` Jan Blunck
2006-03-09 14:36           ` Kirill Korotaev [this message]
2006-03-09 11:36     ` Balbir Singh
2006-03-09 14:42 ` Kirill Korotaev
2006-03-09 16:09   ` Jan Blunck
2006-03-09 16:18     ` Kirill Korotaev
2006-03-09 16:39       ` Jan Blunck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44103D50.7010108@sw.ru \
    --to=dev@sw.ru \
    --cc=akpm@osdl.org \
    --cc=balbir@in.ibm.com \
    --cc=bsingharora@gmail.com \
    --cc=dev@openvz.org \
    --cc=jblunck@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=olh@suse.de \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.