From: j.w.r.degoede@hhs.nl (Hans de Goede)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] Memory usage of sysfs files
Date: Thu, 09 Mar 2006 23:16:18 +0000 [thread overview]
Message-ID: <4410B742.6070400@hhs.nl> (raw)
In-Reply-To: <Pine.LNX.4.63.0603082311220.3051@Laila>
Hi,
I've given this some more thought and I've decided against implementing
my way for a couple of other drivers to be able to really measure the
difference. I believe we agree my way is somewhat more efficient, but
that the differences aren't big enough to swing the scales to my way
only on the efficiency reasons.
Instead of spending more time coding test-cases I'd rather just see a
decision soon and (if nescessarry) I'll update the uguru driver to match .
There are 2 arguments I would still like to make in favor of my way though:
1) you initially did it this way too for atleast one driver. Remember,
usually your first hunch is a good one.
2) I've also written support for libsensors and the sensors application
when doing things my way and that fits nicely. I'm afraid that the many
files way will be a problem with the current libsensors. I don't want to
now wath the lib and the progs chips.* will look like. 100+ additional
entries for the uguru alone! And I don't think the chip specific reading
and report code in the sensors application will get any pretter too.
Now I know that libsensors is destined to be replaced, but it will be
around for a while I think.
I've attached a patch adding support for the uguru to both lib and prog
with alarm reporting to give you an idea how this will look like when
doing things my way. Please note that this patch needs updating for
2.10 / cvs and thus won't apply.
Regards,
Hans
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lm_sensors-2.9.1-uguru.patch
Type: text/x-patch
Size: 15184 bytes
Desc: not available
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20060310/73c52b90/lm_sensors-2.9.1-uguru-0001.bin
next prev parent reply other threads:[~2006-03-09 23:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-08 22:36 [lm-sensors] Memory usage of sysfs files Hartmut Rick
2006-03-09 19:41 ` Jean Delvare
2006-03-09 20:05 ` Hans de Goede
2006-03-09 20:06 ` Hans de Goede
2006-03-09 21:05 ` Jean Delvare
2006-03-09 21:41 ` Hans de Goede
2006-03-09 23:16 ` Hans de Goede [this message]
2006-03-10 11:11 ` Hans de Goede
2006-03-10 13:46 ` Jean Delvare
2006-03-10 14:09 ` Jean Delvare
2006-03-10 15:28 ` Jim Cromie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4410B742.6070400@hhs.nl \
--to=j.w.r.degoede@hhs.nl \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.