From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v3 0/8] R-Car DU: Support CRC calculation Date: Thu, 03 May 2018 15:06:25 +0300 Message-ID: <4411331.L07MOrSnxD@avalon> References: <20180428205027.18025-1-laurent.pinchart+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id A127B6E124 for ; Thu, 3 May 2018 12:06:11 +0000 (UTC) In-Reply-To: <20180428205027.18025-1-laurent.pinchart+renesas@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dave Airlie Cc: Kieran Bingham , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SGkgRGF2ZSwKClBpbmcgPwoKT24gU2F0dXJkYXksIDI4IEFwcmlsIDIwMTggMjM6NTA6MTkgRUVT VCBMYXVyZW50IFBpbmNoYXJ0IHdyb3RlOgo+IEhlbGxvLAo+IAo+IChEYXZlLCB0aGVyZSdzIGEg cmVxdWVzdCBmb3IgeW91IGJlbG93KQo+IAo+IFRoaXMgcGF0Y2ggc2VyaWVzIGFkZHMgc3VwcG9y dCBmb3IgQ1JDIGNhbGN1bGF0aW9uIHRvIHRoZSByY2FyLWR1LWRybQo+IGRyaXZlci4KPiAKPiBD UkMgY2FsY3VsYXRpb24gaXMgc3VwcG9ydGVkIHN0YXJ0aW5nIGF0IHRoZSBSZW5lc2FzIFItQ2Fy IEdlbjMgU29DcywgYXMKPiBlYXJsaWVyIHZlcnNpb25zIGRvbid0IGhhdmUgdGhlIG5lY2Vzc2Fy eSBoYXJkd2FyZS4gT24gR2VuMyBTb0NzLCB0aGUgQ1JDIGlzCj4gY29tcHV0ZWQgYnkgdGhlIERJ U0NPTSBtb2R1bGUgcGFydCBvZiB0aGUgVlNQLUQgYW5kIFZTUC1ETC4KPiAKPiBUaGUgRElTQ09N IGlzIGludGVyZmFjZWQgdG8gdGhlIFZTUCB0aHJvdWdoIHRoZSBVSUYgZ2x1ZSBhbmQgYXBwZWFy cyBhcyBhCj4gVlNQIGVudGl0eSB3aXRoIGEgc2luayBwYWQgYW5kIGEgc291cmNlIHBhZC4KPiAK PiBUaGUgc2VyaWVzIHN0YXJ0cyB3aXRoIGEgc3dpdGNoIHRvIFNQRFggbGljZW5zZSBoZWFkZXJz IGluIHBhdGNoIDEvOCwKPiBwcm9tcHRlZCBieSBhIGNoZWNrcGF0Y2gucGwgd2FybmluZyBmb3Ig YSBsYXRlciBwYXRjaCB0aGF0IGNvbXBsYWluZWQgYWJvdXQKPiBtaXNzaW5nIFNQRFggbGljZW5z ZSBoZWFkZXJzLiBJdCB0aGVuIGNvbnRpbnVlcyB3aXRoIGNsZWFudXAgYW5kCj4gcmVmYWN0b3Jp bmcuIFBhdGNoZXMgMi84IGFuZCAzLzggcHJlcGFyZSBmb3IgRElTQ09NIGFuZCBVSUYgc3VwcG9y dCBieQo+IGV4dGVuZGluZyBnZW5lcmljIGNvZGUgdG8gbWFrZSBpdCB1c2FibGUgZm9yIHRoZSBV SUYuIFBhdGNoIDQvOCBkb2N1bWVudHMgYQo+IHN0cnVjdHVyZSB0aGF0IHdpbGwgcmVjZWl2ZSBu ZXcgZmllbGRzLgo+IAo+IFBhdGNoIDUvOCB0aGVuIGV4dGVuZHMgdGhlIEFQSSBleHBvc2VkIGJ5 IHRoZSBWU1AgZHJpdmVyIHRvIHRoZSBEVSBkcml2ZXIgdG8KPiBzdXBwb3J0IENSQyBjb21wdXRh dGlvbiBjb25maWd1cmF0aW9uIGFuZCByZXBvcnRpbmcuIFRoZSBwYXRjaAo+IHVuZm9ydHVuYXRl bHkgbmVlZHMgdG8gdG91Y2ggYm90aCB0aGUgVlNQIGFuZCBEVSBkcml2ZXJzLCBzbyB0aGUgd2hv bGUKPiBzZXJpZXMgd2lsbCBuZWVkIHRvIGJlIG1lcmdlZCB0aHJvdWdoIGEgc2luZ2xlIHRyZWUu Cj4gCj4gUGF0Y2ggNS84IGFkZHMgc3VwcG9ydCBmb3IgdGhlIERJU0NPTSBhbmQgVUlGIGluIHRo ZSBWU1AgZHJpdmVyLCBwYXRjaCA3LzgKPiBpbnRlZ3JhdGVzIGl0IGluIHRoZSBEUk0gcGlwZWxp bmUsIGFuZCBwYXRjaCA4LzggZmluYWxseSBpbXBsZW1lbnRzIHRoZSBDUkMKPiBBUEkgaW4gdGhl IERVIGRyaXZlciB0byBleHBvc2UgQ1JDIGNvbXB1dGF0aW9uIHRvIHVzZXJzcGFjZS4KPiAKPiBU aGUgaGFyZHdhcmUgc3VwcG9ydHMgY29tcHV0aW5nIHRoZSBDUkMgYXQgYW55IGFyYml0cmFyeSBw b2ludCBpbiB0aGUKPiBwaXBlbGluZSBvbiBhIGNvbmZpZ3VyYWJsZSB3aW5kb3cgb2YgdGhlIGZy YW1lLiBUaGlzIHBhdGNoIHNlcmllcyBzdXBwb3J0cwo+IENSQyBjb21wdXRhdGlvbiBvbiBpbnB1 dCBwbGFuZXMgb3IgcGlwZWxpbmUgb3V0cHV0LCBidXQgb24gdGhlIGZ1bGwgZnJhbWUKPiBvbmx5 LiBTdXBwb3J0IGZvciBDUkMgd2luZG93IGNvbmZpZ3VyYXRpb24gY2FuIGJlIGFkZGVkIGxhdGVy IGlmIG5lZWRlZCBidXQKPiB3aWxsIHJlcXVpcmUgZXh0ZW5kaW5nIHRoZSB1c2Vyc3BhY2UgQVBJ LCBhcyB0aGUgRFJNL0tNUyBDUkMgQVBJIGRvZXNuJ3QKPiBzdXBwb3J0IHRoaXMgZmVhdHVyZS4K PiAKPiBDb21wYXJlZCB0byB2MSwgdGhlIENSQyBzb3VyY2UgbmFtZXMgZm9yIHBsYW5lIGlucHV0 cyBhcmUgbm93IGNvbnN0cnVjdGVkCj4gZnJvbSBwbGFuZSBJRHMgaW5zdGVhZCBvZiBwbGFuZSBp bmRpY2VzLiBUaGlzIGFsbG93cyB1c2Vyc3BhY2UgdG8gbWF0Y2ggQ1JDCj4gc291cmNlcyB3aXRo IHBsYW5lcy4KPiAKPiBDb21wYXJlZCB0byB2MiwgdmFyaW91cyBzbWFsbCBpc3N1ZXMgcmVwb3J0 ZWQgYnkgcmV2aWV3ZXJzIGhhdmUgYmVlbiBmaXhlZC4KPiBJIGJlbGlldmUgdGhlIHNlcmllcyB0 byBub3cgYmUgcmVhZHkgZm9yIHVwc3RyZWFtIG1lcmdlLgo+IAo+IE5vdGUgdGhhdCBleHBvc2lu ZyB0aGUgRElTQ09NIGFuZCBVSUYgdGhvdWdoIHRoZSBWNEwyIEFQSSBpc24ndCBzdXBwb3J0ZWQg YXMKPiB0aGUgbW9kdWxlIGlzIG9ubHkgZm91bmQgaW4gVlNQLUQgYW5kIFZTUC1ETCBpbnN0YW5j ZXMgdGhhdCBhcmUgbm90IGV4cG9zZWQKPiB0aHJvdWdoIFY0TDIuIEl0IGlzIHBvc3NpYmxlIHRv IGV4cG9zZSB0aG9zZSBpbnN0YW5jZXMgdGhyb3VnaCBWNEwyIHdpdGggYQo+IHNtYWxsIG1vZGlm aWNhdGlvbiB0byB0aGUgZHJpdmVyIGZvciB0ZXN0aW5nIHB1cnBvc2UuIElmIHRoZSBuZWVkIGFy aXNlcyB0bwo+IHRlc3QgRElTQ09NIGFuZCBVSUYgd2l0aCBzdWNoIGFuIG91dC1vZi10cmVlIHBh dGNoLCBzdXBwb3J0IGZvciBDUkMKPiByZXBvcnRpbmcgdGhyb3VnaCBhIFY0TDIgY29udHJvbCBj YW4gYmUgYWRkZWQgbGF0ZXIgd2l0aG91dCBhZmZlY3RpbmcgaG93Cj4gQ1JDIGlzIGV4cG9zZWQg dGhyb3VnaCB0aGUgRFJNL0tNUyBBUEkuCj4gCj4gVGhlIHBhdGNoZXMgYXJlIGJhc2VkIG9uIHRv cCBvZiB0aGUgIltQQVRDSCB2MiAwMC8xNV0gUi1DYXIgVlNQMToKPiBEeW5hbWljYWxseSBhc3Np Z24gYmxlbmQgdW5pdHMgdG8gZGlzcGxheSBwaXBlbGluZXMiIHBhdGNoIHNlcmllcywgaXRzZWxm Cj4gYmFzZWQgb24gdG9wIG9mIHRoZSBMaW51eCBtZWRpYSBtYXN0ZXIgYnJhbmNoIGFuZCBzY2hl ZHVsZWQgZm9yIG1lcmdlIGluCj4gdjQuMTguIFRoZSBuZXcgYmFzZSBjYXVzZWQgaGVhdnkgY29u ZmxpY3RzLCByZXF1aXJpbmcgdGhpcyBzZXJpZXMgdG8gYmUKPiBtZXJnZWQgdGhyb3VnaCB0aGUg VjRMMiB0cmVlLgo+IAo+IERhdmUsIEkgaGF2ZSB2ZXJpZmllZCB0aGF0IHRoaXMgc2VyaWVzIG1l cmdlcyBjbGVhbmx5IHdpdGggeW91ciBkcm0tbmV4dCBhbmQKPiBkcm0tZml4ZXMgYnJhbmNoZXMs IHdpdGggdGhlIGRybS1taXNjLW5leHQgYW5kIGRybS1taXNjLWZpeGVzIGJyYW5jaGVzLCBhbmQK PiB3aXRoIHRoZSBSLUNhciBEVSBwYXRjaGVzIEkgd291bGQgbGlrZSB0byBnZXQgbWVyZ2VkIGlu IHY0LjE4IHRocm91Z2ggeW91cgo+IHRyZWUuIENvdWxkIEkgZ2V0IHlvdXIgYWNrIHRvIG1lcmdl IHRoaXMgdGhyb3VnaCB0aGUgVjRMMiB0cmVlID8KPiAKPiBGb3IgY29udmVuaWVuY2UgdGhlIHBh dGNoZXMgYXJlIGF2YWlsYWJsZSBhdAo+IAo+ICAgICAgICAgZ2l0Oi8vbGludXh0di5vcmcvcGlu Y2hhcnRsL21lZGlhLmdpdCB2c3AxLWRpc2NvbS12My0yMDE4MDQyOAo+IAo+IFRoZSBjb2RlIGhh cyBiZWVuIHRlc3RlZCB0aHJvdWdoIHRoZSBrbXMtdGVzdC1jcmMucHkgc2NyaXB0IHBhcnQgb2Yg dGhlIERVCj4gdGVzdCBzdWl0ZSBhdmFpbGFibGUgYXQKPiAKPiAgICAgICAgIGdpdDovL2dpdC5p ZGVhc29uYm9hcmQuY29tL3JlbmVzYXMva21zLXRlc3RzLmdpdCBkaXNjb20KPiAKPiBMYXVyZW50 IFBpbmNoYXJ0ICg4KToKPiAgIHY0bDogdnNwMTogVXNlIFNQRFggbGljZW5zZSBoZWFkZXJzCj4g ICB2NGw6IHZzcDE6IFNoYXJlIHRoZSBDTFUsIExJRiBhbmQgTFVUIHNldF9mbXQgcGFkIG9wZXJh dGlvbiBjb2RlCj4gICB2NGw6IHZzcDE6IFJlc2V0IHRoZSBjcm9wIGFuZCBjb21wb3NlIHJlY3Rh bmdsZXMgaW4gdGhlIHNldF9mbXQgaGVscGVyCj4gICB2NGw6IHZzcDE6IERvY3VtZW50IHRoZSB2 c3AxX2R1X2F0b21pY19jb25maWcgc3RydWN0dXJlCj4gICB2NGw6IHZzcDE6IEV4dGVuZCB0aGUg RFUgQVBJIHRvIHN1cHBvcnQgQ1JDIGNvbXB1dGF0aW9uCj4gICB2NGw6IHZzcDE6IEFkZCBzdXBw b3J0IGZvciB0aGUgRElTQ09NIGVudGl0eQo+ICAgdjRsOiB2c3AxOiBJbnRlZ3JhdGUgRElTQ09N IGluIGRpc3BsYXkgcGlwZWxpbmUKPiAgIGRybTogcmNhci1kdTogQWRkIHN1cHBvcnQgZm9yIENS QyBjb21wdXRhdGlvbgo+IAo+ICBkcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2NydGMu YyAgICB8IDE1NiArKysrKysrKysrKysrKysrLQo+ICBkcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9y Y2FyX2R1X2NydGMuaCAgICB8ICAxNSArKwo+ICBkcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2Fy X2R1X3ZzcC5jICAgICB8ICAxMiArLQo+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvTWFr ZWZpbGUgICAgICB8ICAgMiArLQo+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMS5o ICAgICAgICB8ICAxMCArLQo+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9icngu YyAgICB8ICAgNiArLQo+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9icnguaCAg ICB8ICAgNiArLQo+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9jbHUuYyAgICB8 ICA3MSArKy0tLS0tLQo+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9jbHUuaCAg ICB8ICAgNiArLQo+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9kbC5jICAgICB8 ICAgOCArLQo+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9kbC5oICAgICB8ICAg NiArLQo+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9kcm0uYyAgICB8IDEyNyAr KysrKysrKysrKystLQo+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9kcm0uaCAg ICB8ICAxNSArLQo+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9kcnYuYyAgICB8 ICAyNiArKy0KPiAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfZW50aXR5LmMgfCAx MDMgKysrKysrKysrKystCj4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2VudGl0 eS5oIHwgIDEzICstCj4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2hnby5jICAg IHwgICA2ICstCj4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2hnby5oICAgIHwg ICA2ICstCj4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2hndC5jICAgIHwgICA2 ICstCj4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2hndC5oICAgIHwgICA2ICst Cj4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2hpc3RvLmMgIHwgIDY1ICstLS0t LS0KPiAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfaGlzdG8uaCAgfCAgIDYgKy0K PiAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfaHNpdC5jICAgfCAgIDYgKy0KPiAg ZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfaHNpdC5oICAgfCAgIDYgKy0KPiAgZHJp dmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfbGlmLmMgICAgfCAgNzEgKystLS0tLS0KPiAg ZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfbGlmLmggICAgfCAgIDYgKy0KPiAgZHJp dmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfbHV0LmMgICAgfCAgNzEgKystLS0tLS0KPiAg ZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfbHV0LmggICAgfCAgIDYgKy0KPiAgZHJp dmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfcGlwZS5jICAgfCAgIDYgKy0KPiAgZHJpdmVy cy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfcGlwZS5oICAgfCAgIDYgKy0KPiAgZHJpdmVycy9t ZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfcmVncy5oICAgfCAgNDYgKysrKy0KPiAgZHJpdmVycy9t ZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfcnBmLmMgICAgfCAgIDYgKy0KPiAgZHJpdmVycy9tZWRp YS9wbGF0Zm9ybS92c3AxL3ZzcDFfcndwZi5jICAgfCAgIDYgKy0KPiAgZHJpdmVycy9tZWRpYS9w bGF0Zm9ybS92c3AxL3ZzcDFfcndwZi5oICAgfCAgIDYgKy0KPiAgZHJpdmVycy9tZWRpYS9wbGF0 Zm9ybS92c3AxL3ZzcDFfc3J1LmMgICAgfCAgIDYgKy0KPiAgZHJpdmVycy9tZWRpYS9wbGF0Zm9y bS92c3AxL3ZzcDFfc3J1LmggICAgfCAgIDYgKy0KPiAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92 c3AxL3ZzcDFfdWRzLmMgICAgfCAgIDYgKy0KPiAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3Ax L3ZzcDFfdWRzLmggICAgfCAgIDYgKy0KPiAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3Zz cDFfdWlmLmMgICAgfCAyNzEgKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIGRyaXZlcnMv bWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX3VpZi5oICAgIHwgIDMyICsrKysKPiAgZHJpdmVycy9t ZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfdmlkZW8uYyAgfCAgIDYgKy0KPiAgZHJpdmVycy9tZWRp YS9wbGF0Zm9ybS92c3AxL3ZzcDFfdmlkZW8uaCAgfCAgIDYgKy0KPiAgZHJpdmVycy9tZWRpYS9w bGF0Zm9ybS92c3AxL3ZzcDFfd3BmLmMgICAgfCAgIDYgKy0KPiAgaW5jbHVkZS9tZWRpYS92c3Ax LmggICAgICAgICAgICAgICAgICAgICAgfCAgNDUgKysrKy0KPiAgNDQgZmlsZXMgY2hhbmdlZCwg ODkyIGluc2VydGlvbnMoKyksIDQxNyBkZWxldGlvbnMoLSkKPiAgY3JlYXRlIG1vZGUgMTAwNjQ0 IGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX3VpZi5jCj4gIGNyZWF0ZSBtb2RlIDEw MDY0NCBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV91aWYuaAoKLS0gClJlZ2FyZHMs CgpMYXVyZW50IFBpbmNoYXJ0CgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([213.167.242.64]:33036 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750999AbeECMGL (ORCPT ); Thu, 3 May 2018 08:06:11 -0400 From: Laurent Pinchart To: Dave Airlie Cc: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, Kieran Bingham Subject: Re: [PATCH v3 0/8] R-Car DU: Support CRC calculation Date: Thu, 03 May 2018 15:06:25 +0300 Message-ID: <4411331.L07MOrSnxD@avalon> In-Reply-To: <20180428205027.18025-1-laurent.pinchart+renesas@ideasonboard.com> References: <20180428205027.18025-1-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Dave, Ping ? On Saturday, 28 April 2018 23:50:19 EEST Laurent Pinchart wrote: > Hello, > > (Dave, there's a request for you below) > > This patch series adds support for CRC calculation to the rcar-du-drm > driver. > > CRC calculation is supported starting at the Renesas R-Car Gen3 SoCs, as > earlier versions don't have the necessary hardware. On Gen3 SoCs, the CRC is > computed by the DISCOM module part of the VSP-D and VSP-DL. > > The DISCOM is interfaced to the VSP through the UIF glue and appears as a > VSP entity with a sink pad and a source pad. > > The series starts with a switch to SPDX license headers in patch 1/8, > prompted by a checkpatch.pl warning for a later patch that complained about > missing SPDX license headers. It then continues with cleanup and > refactoring. Patches 2/8 and 3/8 prepare for DISCOM and UIF support by > extending generic code to make it usable for the UIF. Patch 4/8 documents a > structure that will receive new fields. > > Patch 5/8 then extends the API exposed by the VSP driver to the DU driver to > support CRC computation configuration and reporting. The patch > unfortunately needs to touch both the VSP and DU drivers, so the whole > series will need to be merged through a single tree. > > Patch 5/8 adds support for the DISCOM and UIF in the VSP driver, patch 7/8 > integrates it in the DRM pipeline, and patch 8/8 finally implements the CRC > API in the DU driver to expose CRC computation to userspace. > > The hardware supports computing the CRC at any arbitrary point in the > pipeline on a configurable window of the frame. This patch series supports > CRC computation on input planes or pipeline output, but on the full frame > only. Support for CRC window configuration can be added later if needed but > will require extending the userspace API, as the DRM/KMS CRC API doesn't > support this feature. > > Compared to v1, the CRC source names for plane inputs are now constructed > from plane IDs instead of plane indices. This allows userspace to match CRC > sources with planes. > > Compared to v2, various small issues reported by reviewers have been fixed. > I believe the series to now be ready for upstream merge. > > Note that exposing the DISCOM and UIF though the V4L2 API isn't supported as > the module is only found in VSP-D and VSP-DL instances that are not exposed > through V4L2. It is possible to expose those instances through V4L2 with a > small modification to the driver for testing purpose. If the need arises to > test DISCOM and UIF with such an out-of-tree patch, support for CRC > reporting through a V4L2 control can be added later without affecting how > CRC is exposed through the DRM/KMS API. > > The patches are based on top of the "[PATCH v2 00/15] R-Car VSP1: > Dynamically assign blend units to display pipelines" patch series, itself > based on top of the Linux media master branch and scheduled for merge in > v4.18. The new base caused heavy conflicts, requiring this series to be > merged through the V4L2 tree. > > Dave, I have verified that this series merges cleanly with your drm-next and > drm-fixes branches, with the drm-misc-next and drm-misc-fixes branches, and > with the R-Car DU patches I would like to get merged in v4.18 through your > tree. Could I get your ack to merge this through the V4L2 tree ? > > For convenience the patches are available at > > git://linuxtv.org/pinchartl/media.git vsp1-discom-v3-20180428 > > The code has been tested through the kms-test-crc.py script part of the DU > test suite available at > > git://git.ideasonboard.com/renesas/kms-tests.git discom > > Laurent Pinchart (8): > v4l: vsp1: Use SPDX license headers > v4l: vsp1: Share the CLU, LIF and LUT set_fmt pad operation code > v4l: vsp1: Reset the crop and compose rectangles in the set_fmt helper > v4l: vsp1: Document the vsp1_du_atomic_config structure > v4l: vsp1: Extend the DU API to support CRC computation > v4l: vsp1: Add support for the DISCOM entity > v4l: vsp1: Integrate DISCOM in display pipeline > drm: rcar-du: Add support for CRC computation > > drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 156 ++++++++++++++++- > drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 15 ++ > drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 12 +- > drivers/media/platform/vsp1/Makefile | 2 +- > drivers/media/platform/vsp1/vsp1.h | 10 +- > drivers/media/platform/vsp1/vsp1_brx.c | 6 +- > drivers/media/platform/vsp1/vsp1_brx.h | 6 +- > drivers/media/platform/vsp1/vsp1_clu.c | 71 ++------ > drivers/media/platform/vsp1/vsp1_clu.h | 6 +- > drivers/media/platform/vsp1/vsp1_dl.c | 8 +- > drivers/media/platform/vsp1/vsp1_dl.h | 6 +- > drivers/media/platform/vsp1/vsp1_drm.c | 127 ++++++++++++-- > drivers/media/platform/vsp1/vsp1_drm.h | 15 +- > drivers/media/platform/vsp1/vsp1_drv.c | 26 ++- > drivers/media/platform/vsp1/vsp1_entity.c | 103 +++++++++++- > drivers/media/platform/vsp1/vsp1_entity.h | 13 +- > drivers/media/platform/vsp1/vsp1_hgo.c | 6 +- > drivers/media/platform/vsp1/vsp1_hgo.h | 6 +- > drivers/media/platform/vsp1/vsp1_hgt.c | 6 +- > drivers/media/platform/vsp1/vsp1_hgt.h | 6 +- > drivers/media/platform/vsp1/vsp1_histo.c | 65 +------ > drivers/media/platform/vsp1/vsp1_histo.h | 6 +- > drivers/media/platform/vsp1/vsp1_hsit.c | 6 +- > drivers/media/platform/vsp1/vsp1_hsit.h | 6 +- > drivers/media/platform/vsp1/vsp1_lif.c | 71 ++------ > drivers/media/platform/vsp1/vsp1_lif.h | 6 +- > drivers/media/platform/vsp1/vsp1_lut.c | 71 ++------ > drivers/media/platform/vsp1/vsp1_lut.h | 6 +- > drivers/media/platform/vsp1/vsp1_pipe.c | 6 +- > drivers/media/platform/vsp1/vsp1_pipe.h | 6 +- > drivers/media/platform/vsp1/vsp1_regs.h | 46 ++++- > drivers/media/platform/vsp1/vsp1_rpf.c | 6 +- > drivers/media/platform/vsp1/vsp1_rwpf.c | 6 +- > drivers/media/platform/vsp1/vsp1_rwpf.h | 6 +- > drivers/media/platform/vsp1/vsp1_sru.c | 6 +- > drivers/media/platform/vsp1/vsp1_sru.h | 6 +- > drivers/media/platform/vsp1/vsp1_uds.c | 6 +- > drivers/media/platform/vsp1/vsp1_uds.h | 6 +- > drivers/media/platform/vsp1/vsp1_uif.c | 271 +++++++++++++++++++++++++++ > drivers/media/platform/vsp1/vsp1_uif.h | 32 ++++ > drivers/media/platform/vsp1/vsp1_video.c | 6 +- > drivers/media/platform/vsp1/vsp1_video.h | 6 +- > drivers/media/platform/vsp1/vsp1_wpf.c | 6 +- > include/media/vsp1.h | 45 ++++- > 44 files changed, 892 insertions(+), 417 deletions(-) > create mode 100644 drivers/media/platform/vsp1/vsp1_uif.c > create mode 100644 drivers/media/platform/vsp1/vsp1_uif.h -- Regards, Laurent Pinchart