All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kirill Korotaev <dev@sw.ru>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Kirill Korotaev <dev@openvz.org>, Andrew Morton <akpm@osdl.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Al Viro <viro@ftp.linux.org.uk>,
	devel@openvz.org, Andrey Savochkin <saw@saw.sw.com.sg>
Subject: Re: [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations	inside (ver. 3)
Date: Fri, 10 Mar 2006 11:57:09 +0300	[thread overview]
Message-ID: <44113F65.50706@sw.ru> (raw)
In-Reply-To: <1141980385.2876.30.camel@laptopd505.fenrus.org>

>>Andrew,
>>
>>Fixed both comments from Al Viro (thanks, Al):
>>- should have a separate helper
>>- should pass 0 instead of GFP_KERNEL in page_symlink()
> 
> 
>> 
>>+	page = find_or_create_page(mapping, 0,
>>+			mapping_gfp_mask(mapping) | gfp_mask);
> 
> 
> 
> 
> this does not work; GFP_NOFS has a bit *LESS* than GFP_KERNEL, not a bit
> more. As such a | operation isn't going to be useful....
> 
> (So I think that while Al's intention was good, the implication of it
> isn't ;)
Oh no... Had to sleep well today... :/
Al, are you agree with the original patch then?
I don't think it is a good idea to introduce AND mask instead :)

Thanks,
Kirill


  parent reply	other threads:[~2006-03-10  8:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-10  8:46 [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside (ver. 3) Kirill Korotaev
2006-03-10  8:46 ` Arjan van de Ven
2006-03-10  8:56   ` Andrew Morton
2006-03-10  9:11     ` Kirill Korotaev
2006-03-10  8:57   ` Kirill Korotaev [this message]
2006-03-10  8:59   ` Al Viro
2006-03-10  9:40     ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44113F65.50706@sw.ru \
    --to=dev@sw.ru \
    --cc=akpm@osdl.org \
    --cc=arjan@infradead.org \
    --cc=dev@openvz.org \
    --cc=devel@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=saw@saw.sw.com.sg \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.